Skip to content

Hindi Translation added #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

Yugal41735
Copy link
Contributor

Summary

Added Hindi Translation

image

Ref => #48

Type of change

  • Bug fix (added a non-breaking change which fixes an issue)
  • New feature (added a non-breaking change which adds functionality)
  • Updated documentation (updated the readme, templates, or other repo files)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Added or updated test cases to test new features

@vercel
Copy link

vercel bot commented Oct 15, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ytcards ✅ Ready (Inspect) Visit Preview Oct 16, 2022 at 1:57PM (UTC)

@DenverCoder1
Copy link
Owner

Hi, sorry I didn't get to merge this one.

#60 was opened about an hour and a half before yours so I ended up merging that one.

I did notice, however, that your translation for "months" and "years" appears to be slightly different.

Let me know if you think the translations in your PR should override the ones in #60, otherwise I'll close this. Hopefully, we will see some contributions from you merged in the future.

@Yugal41735
Copy link
Contributor Author

months one could be edited.

@Yugal41735
Copy link
Contributor Author

If you want I can do those changes.

@DenverCoder1
Copy link
Owner

I suppose you could look at youtube.com with language set to Hindi and see what they do for translating these. If you can make it accurate to the YouTube site (if it's not already), that would be good.

Also note, the filename should be hi.yml for Hindi and the first line should be hi:.

If you merge main, which it seems you did, you should see the file.

@DenverCoder1
Copy link
Owner

Looks like YouTube uses माह पहले for months and वर्ष पहले for years which is what we currently have, so I suppose there's no need to update it. I believe this is what #60 already has.

image

Let me know if you find anything different, but I will close for now. 👍

@Yugal41735 Yugal41735 deleted the Hindi_Translation branch October 16, 2022 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants