Skip to content

Fixed the method type matching and the handler type matching #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mridang
Copy link
Contributor

@mridang mridang commented Dec 25, 2018

The plugin breaks when the method name is in uppercase and if the handler name contains multiple dots.

Here's a snippet from my serverless configuration file that causes the plugin to break.

functions:
  minified:
    handler: handler.mininify
    events:
    - http:
        path: polyfill.min.js
        method: GET
        cors:
          origin: '*'
          maxAge: 86400
          allowCredentials: true

@DianaIonita
Copy link
Owner

Hey @mridang,

Many thanks for your contribution. Looks good - would you mind quickly adding a test as proof that it works and also as living documentation?
Thanks again!

@DianaIonita DianaIonita merged commit bba0f34 into DianaIonita:develop Jan 22, 2019
@DianaIonita DianaIonita mentioned this pull request Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants