Experiment: Relax lifetime requirements further #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually… things seem to be working fine with the latest commit? I'll need to come back to it with a much fresher mind to convince myself I'm not introducing unsoundness, that said 😄 |
This was referenced Mar 18, 2025
|
Hmm so coming back to it today it does look safe to me. @touilleMan Can you confirm this looks safe to you too? If yes I'll just come back to it in a few day, self-review again and if it still looks good to me probably land 😄 |
touilleMan
added a commit
to Scille/parsec-cloud
that referenced
this pull request
Mar 26, 2025
…i.e. to-be-merged PR Ekleog/indexed-db#12)
touilleMan
added a commit
to Scille/parsec-cloud
that referenced
this pull request
Mar 26, 2025
…i.e. to-be-merged PR Ekleog/indexed-db#12)
touilleMan
added a commit
to Scille/parsec-cloud
that referenced
this pull request
Mar 27, 2025
…i.e. to-be-merged PR Ekleog/indexed-db#12)
github-merge-queue bot
pushed a commit
to Scille/parsec-cloud
that referenced
this pull request
Mar 27, 2025
…i.e. to-be-merged PR Ekleog/indexed-db#12)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@touilleMan I ended up giving up on also relaxing constraints on the version change transaction's closure 😢
If you're interested, you may want to look at the stage I had reached? With the introduction of the
ScopeCallbackI can reasonably safely extend the lifetimes, but now I'm hitting a weird rustc rejection that claims that my scope is not'static, even though… AFAICTfn(&'a ()) -> &'a ()should be'static, but it's actually not 🤷