Skip to content

Adding large numbers of HTLCs at once crashes channeld. #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rustyrussell opened this issue Sep 27, 2017 · 0 comments
Closed

Adding large numbers of HTLCs at once crashes channeld. #289

rustyrussell opened this issue Sep 27, 2017 · 0 comments
Assignees
@rustyrussell
Labels
bug
Milestone
v0.6

Comments

@rustyrussell
Copy link
Contributor

The message gets too big for 64k. We need to handle at least 483 additions (the current limit), and each one contains the complete onion of 1366 bytes, and 483 removes (each with a failure message of up to 65534 bytes).

Say 64MB to be sure.
@rustyrussell rustyrussell self-assigned this Sep 27, 2017
@rustyrussell rustyrussell added this to the v0.6 milestone Sep 27, 2017
rustyrussell added a commit to rustyrussell/lightning that referenced this issue Sep 28, 2017
@rustyrussell
wire: use 26-bit lengths for inter-daemon messaging.
a57c377 
Fixes: ElementsProject#289
Signed-off-by: Rusty Russell <[email protected]>
rustyrussell added a commit to rustyrussell/lightning that referenced this issue Oct 9, 2017
@rustyrussell
wire: use 26-bit lengths for inter-daemon messaging.
5a06d99 
Fixes: ElementsProject#289
Signed-off-by: Rusty Russell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rustyrussell rustyrussell

Labels
bug
Projects
None yet
Milestone
v0.6
Development

No branches or pull requests
1 participant
@rustyrussell