Skip to content

wire: fix up lease_rates patch to what was actually applied #4755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2021

Conversation

rustyrussell
Copy link
Contributor

@rustyrussell rustyrussell commented Sep 1, 2021

Running make extract-peer-csv gives the wrong result, so fix the patch.

@niftynei
Copy link
Contributor

niftynei commented Sep 1, 2021

ACK rustyrussell@0745f9d

afaict this commit brings the patch up to date with the peer_wire.csv, as well as the current proposed draft. Seems like I updated the peer_wire.csv without patching the patchfile that it should be generated from. Yikes.

lightning/bolts@6751029#diff-ed04ca2c673fd6aabde69389511fa9ee60cb44d6b2ef6c88b549ffaa753d6afeR989

@rustyrussell rustyrussell changed the title wire: revert the unapplied changes to lease_rates. wire: fix up lease_rates patch to what was actually applied Sep 2, 2021
Running `make extract-peer-csv` changes peer_wire.csv, @niftynei
points out that the patch file is wrong (peer_wire.csv is correct).

(Any attempt to regenerate the csv files from the specs hits this issue)

Signed-off-by: Rusty Russell <[email protected]>
@rustyrussell rustyrussell merged commit 0a05bcd into ElementsProject:master Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants