CHANGELOG.md: order into a more user-first ordering. #5723
Conversation
There was a problem hiding this comment.
ACK d9f5ca0
regarding the rust and python changes what about putting a filter in front of Changelog-None(rust-grpc) in this way from the git history, we can generate the changelog by scope. I had a tool that already do this but required some more love to be shipped with cln. But if you want I can spend some time testing it and we will see if it is possible to integrate it. I think should be trivial, I use it in all monorepo repositories and make the job
|
I think the simple prefix is correct, but our prefix choices need work. We're not just JSON any more: perhaps we should change this to simply API? |
|
I agree!
Yes, I think have a section regarding the API added and changed would be really interesting for the user that just does not care really about the internal. I would also propose that we should generate our own changelog for the python client package and rust packages, because right now the changes are a little bit hide in the darkness of cln changes |
And internal changes don't get CHANGELOG entries, so removed "- Added interactive transaction building routine ([ElementsProject#5287])". We need to come up with some way of marking rust crate changes, as it's not immediately obvious what "- cln-plugin" means? Maybe we switch from JSON-RPC to Control as a more general prefix? Signed-off-by: Rusty Russell <[email protected]>
This should have been merged into master earlier! Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
force-pushed
the
CHANGELOG-cleanup
branch
from
d9f5ca0 to
e937c82
Compare
|
ACK e937c82 |
And internal changes don't get CHANGELOG entries, so removed "- Added interactive transaction building routine ([#5287])".
We need to come up with some way of marking rust crate changes, as it's not immediately obvious what "- cln-plugin" means?
Maybe we switch from JSON-RPC to Control as a more general prefix?
Changelog-None