Skip to content

splice: Gossip new scid on splice_lock #6694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

ddustin
Copy link
Collaborator

@ddustin ddustin commented Sep 19, 2023

Reset scid announced flag so the gossip system can re-announce it.

Fixes #6572
Fixes #6481

Todo:

  • Splice gossip test, l1 -> l2 splice, 6 blocks, confirm l3 sees the newly spliced channel
  • Splice gossip test, l1 -> l2 splice, 12+ blocks, confirm l3 no longer sees original channel
  • Merge channel_announcement errors into this PR

@ddustin ddustin added this to the v23.11 milestone Sep 19, 2023
@ddustin ddustin marked this pull request as draft September 19, 2023 19:23
@ddustin ddustin modified the milestones: v23.11, v23.08 Point Releases Sep 19, 2023
@ddustin ddustin force-pushed the ddustin/splice_gossip branch from ce3e7bd to 4816dcd Compare September 19, 2023 21:02
Reset scid announced flag so the gossip system can re-announce it, and add test the confirm the new channel is seen after 6 blcoks and the old one drops after 12+ blocks.

ChageLog-Fixed: Scid gossip fix for splices.
@ddustin ddustin force-pushed the ddustin/splice_gossip branch from 4816dcd to b0af2a2 Compare September 19, 2023 21:04
@ddustin ddustin self-assigned this Sep 19, 2023
@ddustin ddustin marked this pull request as ready for review September 19, 2023 21:06
@ddustin
Copy link
Collaborator Author

ddustin commented Sep 20, 2023

Merging into #6677

@ddustin ddustin closed this Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid local_channel_announcement after a successful splice Splicing Gossip
1 participant