forked from rust-lang/rust
-
Notifications
You must be signed in to change notification settings - Fork 8
Wrong error message for using the wrong macro "style" for the autodiff macro #185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Zalathar
added a commit
to Zalathar/rust
that referenced
this issue
Apr 10, 2025
…eyouxu emit a better error message for using the macro incorrectly fixing: EnzymeAD#185 I feel like it's not a perfect message either, so I'm open to suggestions. But at the end of the day users will need to read the docs anyway, and emitting multi-line errors each time this gets triggered can probably become annoying? r? `@jieyouxu` since you've reviewed my frontend work back in the days. Tracking: - rust-lang#124509
Zalathar
added a commit
to Zalathar/rust
that referenced
this issue
Apr 10, 2025
…eyouxu emit a better error message for using the macro incorrectly fixing: EnzymeAD#185 I feel like it's not a perfect message either, so I'm open to suggestions. But at the end of the day users will need to read the docs anyway, and emitting multi-line errors each time this gets triggered can probably become annoying? r? `@jieyouxu` since you've reviewed my frontend work back in the days. Tracking: - rust-lang#124509
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this issue
Apr 10, 2025
…eyouxu emit a better error message for using the macro incorrectly fixing: EnzymeAD#185 I feel like it's not a perfect message either, so I'm open to suggestions. But at the end of the day users will need to read the docs anyway, and emitting multi-line errors each time this gets triggered can probably become annoying? r? ``@jieyouxu`` since you've reviewed my frontend work back in the days. Tracking: - rust-lang#124509
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this issue
Apr 10, 2025
Rollup merge of rust-lang#139563 - EnzymeAD:better-autodiff-err, r=jieyouxu emit a better error message for using the macro incorrectly fixing: EnzymeAD#185 I feel like it's not a perfect message either, so I'm open to suggestions. But at the end of the day users will need to read the docs anyway, and emitting multi-line errors each time this gets triggered can probably become annoying? r? ``@jieyouxu`` since you've reviewed my frontend work back in the days. Tracking: - rust-lang#124509
@sYgbpNA5UEVufjsHNwF3Xvf9ANZi5bNs Both of your issues should be resolved now, but please let me know if you find other ways to break it. Frontend bugs are a great way to get new contributors started, so I always appreciate them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
rustc +enzyme -vV
output:rustc 1.84.0-nightly (1203575 2024-10-30)
binary: rustc
commit-hash: 1203575
commit-date: 2024-10-30
host: x86_64-unknown-linux-gnu
release: 1.84.0-nightly
LLVM version: 19.1.1
example:
complilation error:
while both are wrong the error message stating the macro must be applied to functions only doesn't make sense here.
I don't know how the macro styles like
#[foo]
as opposed to#[foo(Bar)]
are referred to hence the "style" in the titleThe text was updated successfully, but these errors were encountered: