Skip to content

MAUI Viewer search update #1204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2023
Merged

MAUI Viewer search update #1204

merged 2 commits into from
Apr 3, 2023

Conversation

duffh
Copy link
Collaborator

@duffh duffh commented Mar 31, 2023

Description

Fixed search text input in the MAUI sample viewer.

Type of change

  • Bug fix

Platforms tested on

  • MAUI WinUI
  • MAUI Android
  • MAUI iOS
  • MAUI MacCatalyst

Checklist

  • Self-review of changes
  • All changes work as expected on all affected platforms
  • There are no warnings related to changes
  • Code is commented and follows .NET conventions and standards
  • Codemaid and XAML styler extensions have been run on every changed file
  • No unrelated changes have been made to any other code or project files

@duffh duffh changed the base branch from main to v.next March 31, 2023 15:14
@andy-weis
Copy link
Collaborator

Tested on MacCatalyst and iOS. Looks good, approved. Only further improvement I can think of is to remove any mistyped punctuation marks as that would create the same issue as trailing whitespace (on a couple occasions I accidentally added a period and all search results were dropped). Doesn't seem like much of an issue though, so up to you.

Copy link
Collaborator

@andy-weis andy-weis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

Copy link
Collaborator

@williambohrmann3 williambohrmann3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix is good. Just curious why we're updating v.next package references in this PR?

@duffh duffh merged commit f112faf into v.next Apr 3, 2023
@duffh duffh deleted the hduff/MauiViewerSearchUpdate branch April 3, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants