Skip to content

Improve MAUI sample viewer thumbnail size on tablets #1214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 14, 2023

Conversation

duffh
Copy link
Collaborator

@duffh duffh commented Apr 13, 2023

Description

Reduced the size of sample thumbnails on tablets to improve the appearance of the grid view.

Type of change

  • Sample viewer enhancement

Platforms tested on

  • MAUI WinUI
  • MAUI Android
  • MAUI iOS
  • MAUI MacCatalyst

Checklist

  • Self-review of changes
  • All changes work as expected on all affected platforms
  • There are no warnings related to changes
  • Code is commented and follows .NET conventions and standards
  • Codemaid and XAML styler extensions have been run on every changed file
  • No unrelated changes have been made to any other code or project files

@@ -33,7 +33,7 @@ public CategoryViewModel(List<SampleInfo> sampleInfos, string category)

// For tablets check to see if multiple images could fit rather than one tablet sized image.
// If multiple images of arbitrary size "400" would fit then update the image width.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be "300" now?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@duffh duffh merged commit e4d66fc into v.next Apr 14, 2023
@duffh duffh deleted the hduff/reduce-maui-thumbnail-size branch April 14, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants