Skip to content

Add an integrated mesh layer #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 24, 2019
Merged

Add an integrated mesh layer #306

merged 3 commits into from
Jan 24, 2019

Conversation

tschie
Copy link
Contributor

@tschie tschie commented Jan 23, 2019

Demonstrates the new IntegratedMeshLayer type.

@tschie tschie requested a review from Rachael-E January 23, 2019 18:40
Copy link
Collaborator

@Rachael-E Rachael-E left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks great @tschie! Code is good, no changes required there. I've suggested an expansion to the README to make the difference between an integrated mesh and elevation source clearer. If you're happy with this then we'll need to update the design for this sample too.


<h2>Use Case</h2>

<p>An integrated mesh can represent artificial and natural 3D features such as
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having now seen the sample, I think it would be good to explain a little more what the integrated mesh actually is when compared with the elevation source layer. It's not instantly obvious to a new user that it contains more detail than the standard elevation source, and the difference becomes clearer whilst panning to the margins of the integrated mesh layer. Suggest explicitly pointing out that difference, maybe in a "How to use this sample" section to encourage the user to compare and contrast the mesh with elevation source layer.

"An IntegratedMeshLayer typically provides more detail than an ArcGISElevationSourceLayer. For example, it may have higher resolution imagery/textures (seen in this sample on the cliff face in Yosemite) and detailed elevation data. To appreciate the latter, navigate to the edge of the integrated mesh layer in this sample and compare tree elevations with the standard elevation source layer."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rachael-E Could you open a PR for a design readme addition so others on the team can add their feedback?

I have heard that some products (not Runtime yet) can use the data of an integrated mesh as an elevation source for a surface. So I'm not sure they are meant to compete. I'm also wondering if pointing out the contrast in elevation detail here only highlights how low density the world elevation source is (as it should be at world scale). A local elevation source might have comparable detail (lacking trees, since ground elevation sources should ignore those). Lastly, the elevation accuracy is only as good as the imagery, radar/lidar data, and stitching algorithm that formed the mesh. You could have an integrated mesh with only 4 images, whose elevation data would be worse than the world elevation source. You're right that you will typically find meshes with higher resolution elevation, but I don't know if that is an intrinsic property of meshes.

@tschie tschie merged commit e1edbfe into dev Jan 24, 2019
@tschie tschie deleted the add-an-integrated-mesh-layer branch January 24, 2019 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants