Load WFS with XML query sample #335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'master' into dev
Merge pull request master into dev (following sketch on map sample implementation)
Merge branch "master" into "dev"
Merge master into dev following FeatureCollectionLayerQuery implementation
Update README to alert Java 11 users to potential exceptions which may occur when running the project. Providing a suggested workaround from the OpenJavaFX docs.
Update README.md
* Create MapReferenceScaleSample.java * Set up MVC structure for sample * Set up basic map with MVC structure * Added label which updates scale of map as it changes * Set up means to change the map view to the selected reference scale * Set up check boxes for map layers * Update MapReferenceScaleController.java * Update MapReferenceScaleController.java * Allow string in combobox, split to return double to feed into map reference scale * Link checkbox with map layer to set reference scale * Method descriptions and remove unused imports * Fix indents * Create MapReferenceScale.png * Create README.md * Convert markdown to HTML * Addressed comments from review. ComboBox now double, vBoxes will load after map has loaded * Add a method to handle setting the reference scale when interacting with the combobox and the scale sync button. * Code updates following review removed unneeded label, added if loaded statement, and refactored map reference scale. Also updated Readme to account for behavior change. * move checkbox logic in with instanceof check * Update MapReferenceScaleController.java
* Camera controller US english update (#320) * Replace "aeroplane" with "plane" in README and code * Update image to show corrected spelling * Fix grammar * Updates to Tiled Layer to show support for .tkpx files (#321) * Updates to tiled layer, including .tpkx support * Update tile cache readme to include support .tpkx
* Allow downloading of non zip sample data
* point scene layer sample
* Camera controller US english update (#320) * Replace "aeroplane" with "plane" in README and code * Update image to show corrected spelling * Fix grammar * Updates to Tiled Layer to show support for .tkpx files (#321) * Updates to tiled layer, including .tpkx support * Update tile cache readme to include support .tpkx * Update slider to show values from 1-5 rather than 0-5 (#328)
* remove online elevation data source * remove unneeded ArcGISScene object
* Initiating sample with Scene URL * add done loading listener for changes * portal item entry for data * Add readme and image * Update ViewContentBeneathTerrainSurfaceSample.java * update build and refactor float code * Update ViewContentBeneathTerrainSurfaceSample.java * Add layer view state changed listener * Update ViewContentBeneathTerrainSurface.png * Address comments following review * update comment for add done loading listener on to scene * Update README.md * remove unused imports
group layers sample
* play a kml tour sample
* added dialog box for choosing which basemap to use * Update GenerateOfflineMapWithLocalBasemap.java * Update GenerateOfflineMapWithLocalBasemap.java * Update build.gradle * refactoring and neatening up the code * Update GenerateOfflineMapWithLocalBasemap.java * Ensure that the file exists before prompting user to find local file * Move standard code into private methods to draw attention to new API functionality * Add image and README * Update GenerateOfflineMapWithLocalBasemap.java * Update build.gradle * code restructuring (#333) * code restructuring * comment edits * Update image and readme * update description of generateOfflineMapDialog class * convert fields to local variables * convert readme from md to html
tschie
suggested changes
Apr 16, 2019
src/main/java/com/esri/samples/ogc/wfs_xml_query/WfsXmlQuerySample.java
Outdated
Show resolved
Hide resolved
src/main/java/com/esri/samples/ogc/wfs_xml_query/WfsXmlQuerySample.java
Outdated
Show resolved
Hide resolved
src/main/java/com/esri/samples/ogc/wfs_xml_query/WfsXmlQuerySample.java
Outdated
Show resolved
Hide resolved
src/main/java/com/esri/samples/ogc/wfs_xml_query/WfsXmlQuerySample.java
Outdated
Show resolved
Hide resolved
src/main/java/com/esri/samples/ogc/wfs_xml_query/WfsXmlQuerySample.java
Outdated
Show resolved
Hide resolved
|
thanks @tschie. I've added an xml file into resources to avoid using raw XML in the code. Can you take another look please? |
|
I think you missed the |
tschie
approved these changes
Apr 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The next WFS sample ready to review please @tschie, thanks!