Skip to content

patch oAuth sample custom challengehandler #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 20, 2019
Merged

patch oAuth sample custom challengehandler #366

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
97705bf
implement fix for javafx webengine
JonLavi Jun 17, 2019
37a9d4c
formatting
JonLavi Jun 17, 2019
b485595
add fix for create and save map sample
JonLavi Jun 18, 2019
4ed3616
markdown to html formatting
JonLavi Jun 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/com/esri/samples/portal/oauth/OAuthChallengeHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ static String getAuthorizationCode(String authorizationUrl) throws Exception {
dialog.setScene(new Scene(browser, 450, 450));
dialog.show();
WebEngine webEngine = browser.getEngine();
webEngine.load(authorizationUrl);
webEngine.load(authorizationUrl + "&display=classic");

// read the HTTP response to user action
webEngine.setOnStatusChanged(event -> {
Expand Down
4 changes: 4 additions & 0 deletions src/main/java/com/esri/samples/portal/oauth/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,3 +36,7 @@ access token. This access token is used later to access user's profile.</p>
<li>Portal</li>
<li>PortalUser</li>
</ul>

<h2>Additional information</h2>

<p>The JavaFX <code>WebEngine</code> used in this sample may not support rendering of some modern web elements returned by the <code>AuthorizationURL</code>. For this reason, we append <code>&display=classic</code> to the authorization URL, to ensure it renders properly.</p>