100.6.0 #400
Merged
100.6.0 #400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'master' into dev
Merge pull request master into dev (following sketch on map sample implementation)
Merge branch "master" into "dev"
Merge master into dev following FeatureCollectionLayerQuery implementation
Update README to alert Java 11 users to potential exceptions which may occur when running the project. Providing a suggested workaround from the OpenJavaFX docs.
Update README.md
* update RAEDME.metadata.json * update tags in README.metadata.json
* patch-closest-facility-static-readme (#363) * delete sample calculate distance 3D (#365) * Patch/ClosestFacilityStatic- Edit readme 'how to use' (#364) * patch oAuth sample custom challengehandler (#366) * implement fix for javafx webengine * formatting * add fix for create and save map sample * markdown to html formatting * corrects WKID to 4326 (#389) * corrects WKID to 4326 * use SpatialReferences.getWgs84 * move local data download logic to settings.gradle * move data download logic to settings.gradle * fix data paths
* update DictionarySymbolStyle constructor * update README.md and comments * update Item ID * update constructor in remaining samples * update README.md, README.metadata.json * optimise imports * update xml files to remove control points * get Mil2525d xml from AGOL where applicable * remove xml in resources * move data download to settings.gradle, fix paths
* initial commit * working sample * refactoring * refactoring, comments * copyright statement in Launcher class * data download to settings.gradle * change expiration display to static date, CSS edits * update screenshot * expiration message to sentence case * fix settings.gradle. Again. * plement review suggestions * formatting * update README.metadata.json * comments
* show scale in label * load mmpk * add checkboxes with labels * activate checkboxes, change checkbox text color dynamically * update label color * fix checkboxes, comments * optimise imports, copyright comment * labels and screenshot * update screenshot * update runtime build, update README.md * mmpk to class member * formatting and comments * javadoc comments * restore show_callout files * move downloading of sample data to settings.gradle * fix package naming * move scale label to control panel, check mmpk contains maps * fix checkbox text colours * UI fixes and label colouring * data download in settings.gradle * update README.md * update screenshot for UI changes * fix settings.gradle * fix settings.gradle * formatting * README.metadata.json redirect url to blank string * update README.md
I think I'm not too worried about including them because they are mostly all the same and I think git would deduplicate them. |
|
Just noticed that 'eclipse_proj.png' and 'intellij_proj.png' aren't representative any more following the split structure. |
Rachael-E
approved these changes
Aug 21, 2019
There was a problem hiding this comment.
just noticed a small formatting change to be made, other than that looks good I think. @tschie , we were discussing adding in the Javadoc to each build.gradle. I think it would make sense to add that in now, what do you think?
plugins {
id 'application'
id 'org.openjfx.javafxplugin' version '0.0.5'
id 'idea'
id 'eclipse'
}
idea.module.downloadJavadoc = true
eclipse.classpath.downloadJavadoc = true
README.md
Outdated
| 1. Click *Import Projects* from the Welcome Screen or select *File > New > Project from Existing Sources*. | ||
| 2. In the select path dialog, select the `build.gradle` file in the `arcgis-runtime-samples-java` directory. Click *OK* after specifying the `build.gradle` file. | ||
| 3. Click *OK* at the next dialog to complete the import. | ||
| first time you call the `run` task. To refresh the data, you can run the `clean` and `unpackData` tasks. |
There was a problem hiding this comment.
minor thing, looks like the continuation of this sentence has jumped onto a new line
|
@Rachael-E This close to the release, I'd prefer not to add those plugins. We can certainly do it right after the release though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated samples and new samples for version 100.6.0
100.6.0branch look and behave correctly.