Fclfp hardik #463

hardikc07 · 2020-03-24T22:25:01Z

No description provided.

changes in build.gradle file

JonLavi

Nice work @hardikc07! Well done on doing the full MVC pattern on this sample. It certainly is a good exercise. However I think in this sample we can make the UI in the main file, and don't need a Controller file and fxml, since it's a very small amount of UI (1 Text field and 1 button). Other than that, the code looks quite good. If you could restructure the sample to only be in one file, I'll have another closer look. Also, don't forget to update the README.metadata.json file. It's not the most exciting bit of work, but we definitely need it for the Developer Page to work correctly.

feature_layers/feature-collection-layer-from-portal/README.md

feature_layers/feature-collection-layer-from-portal/README.metadata.json

JonLavi · 2020-03-25T08:48:00Z

...samples/feature_collection_layer_from_portal/FeatureCollectionLayerFromPortalController.java

+
+                // load the portal and add the portal item
+                Portal portal = new Portal("https://www.arcgis.com/");
+                System.out.println(FeatureCollectionItemIdTextField.getText());


Don't forget to get rid of all the console logging when you're finished 😉 Happens to me too, so no worries!

JonLavi · 2020-03-25T08:50:28Z

...samples/feature_collection_layer_from_portal/FeatureCollectionLayerFromPortalController.java

+                // create feature collection and add to the map as a layer
+                FeatureCollection featureCollection = new FeatureCollection(portalItem);
+                FeatureCollectionLayer featureCollectionLayer = new FeatureCollectionLayer(featureCollection);
+                map.getOperationalLayers().add(featureCollectionLayer);


In general the pattern we try and promote is to only add the layers to the map's operational layers after we've checked that the appropriate resource has loaded successfuly.
So in this case I'd suggest putting this block of code where you create the FeatureCollection and Layer from the Portal inside the if (portalItem.getLoadStatus() == LoadStatus.LOADED) { statement on line 80

JonLavi · 2020-03-25T08:51:03Z

...sri/samples/feature_collection_layer_from_portal/FeatureCollectionLayerFromPortalSample.java

@@ -0,0 +1,64 @@
+/*
+ * Copyright 2016 Esri.


Don't forget to update the copyright year 😉

Suggested change

* Copyright 2016 Esri.

* Copyright 2020 Esri.

JonLavi · 2020-03-25T08:52:37Z

...sri/samples/feature_collection_layer_from_portal/FeatureCollectionLayerFromPortalSample.java

+  @Override
+  public void start(Stage stage) throws IOException {
+    // set up the scene
+    FXMLLoader loader = new FXMLLoader(getClass().getResource("/fclfp.fxml"));


I don't think we need to keep the MVC structure here, but just pointing out that it would be best to name the fxml file with a more clear file name (generally the samples name with underscores), so feature_collection_layer_from_portal.fxml

JonLavi · 2020-03-25T08:53:42Z

feature_layers/feature-collection-layer-from-portal/src/main/resources/style.css

@@ -0,0 +1,27 @@
+.panel-region .label {


Going forward we're trying to limit this CSS file to only the rules that are being used. Once you've changed the sample to only only live in one file, just check which of these you are using, and delete the rest.

Co-Authored-By: Jonathan Lavi <[email protected]>

removed controller file , added code into one java file and also removed fxml/css file

JonLavi

Nice work @hardikc07 ! It's looking a lot more concise now. There's just a bit of rearranging of the code I would suggest, so that it's easier for users to follow the main workflow. I've also found a few places where we can make the comment style more consistent. Give me a shout if you have any questions!

feature_layers/feature-collection-layer-from-portal/README.md

feature_layers/feature-collection-layer-from-portal/README.metadata.json

...sri/samples/feature_collection_layer_from_portal/FeatureCollectionLayerFromPortalSample.java

feature_layers/feature-collection-layer-from-portal/README.metadata.json

JonLavi · 2020-03-30T07:52:57Z

...sri/samples/feature_collection_layer_from_portal/FeatureCollectionLayerFromPortalSample.java

+        featureCollection = new FeatureCollection(portalItem);
+        featureCollectionLayer = new FeatureCollectionLayer(featureCollection);
+
+        featureCollectionLayer.loadAsync();


If you add the line map.getOperationalLayers().add(featureCollectionLayer); above, it would automatically trigger loading the layer, so you can get rid of the 'loadAsync();call here. I think generally the trick with loadables is that if you're adding them to the map or performing some sort of operation with them, they will start loading by themselves. If you just instantiate them and do nothing else, you'd need theloadAsync()`.

JonLavi · 2020-03-30T07:55:34Z

...sri/samples/feature_collection_layer_from_portal/FeatureCollectionLayerFromPortalSample.java

+                if (!"".equals(input.getText())) {
+                    fetchFeatureCollectionFromPortal();
+                } else {
+                    new Alert(Alert.AlertType.ERROR, "Portal Itemid is empty. Please enter a portal item id.").show();


We can do this check for the contents of the inputTextBox directly in the method fetchFeatureCollectionFromPortal(). That way all you have to do is:

fetchFromPortal.setOnAction(e -> fetchFeatureCollectionFromPortal());

...sri/samples/feature_collection_layer_from_portal/FeatureCollectionLayerFromPortalSample.java

JonLavi · 2020-03-30T07:59:47Z

...sri/samples/feature_collection_layer_from_portal/FeatureCollectionLayerFromPortalSample.java

+
+        //create portal and portal item
+        portal = new Portal("https://www.arcgis.com/");
+        PortalItem portalItem = new PortalItem(portal, input.getText());


You can do the check for the contents of the portal item directly after this, then continue creating the FCL. At the end of the block you can then show an error if it's not a valid item:

if (portalItem.getType() == PortalItem.Type.FEATURE_COLLECTION) { // create a feature collection from the portal item // create a feature collection layer // add the feature collection layer to the map else { // show the error }

JonLavi · 2020-03-30T08:00:46Z

gradle/wrapper/gradle-wrapper.properties

@@ -1,5 +1,6 @@
+#Wed Mar 25 17:43:43 PDT 2020


I don't think we need to keep this comment in here.

making changes as per review by jonathan Co-Authored-By: Jonathan Lavi <[email protected]>

tschie · 2020-03-30T22:31:32Z

feature_layers/feature-collection-layer-from-portal/README.metadata.json

+        "id", 
+        "item", 
+        "map",
+        "notes, 


missing " which is why GitHub is showing this as invalid JSON.

Suggested change

"notes,

"notes",

tschie · 2020-03-30T22:33:48Z

...sri/samples/feature_collection_layer_from_portal/FeatureCollectionLayerFromPortalSample.java

+            stage.show();
+
+
+            // create a new ArcGISMap with an oceans Basemap


Suggested change

// create a new ArcGISMap with an oceans Basemap

// create a new ArcGISMap with the oceans basemap

tschie · 2020-03-30T22:34:02Z

...sri/samples/feature_collection_layer_from_portal/FeatureCollectionLayerFromPortalSample.java

+            // create a new ArcGISMap with an oceans Basemap
+            map = new ArcGISMap(Basemap.createOceans());
+
+            // create a map view and set the ArcGISMap to it


Suggested change

// create a map view and set the ArcGISMap to it

// create a map view and set the map to it

...sri/samples/feature_collection_layer_from_portal/FeatureCollectionLayerFromPortalSample.java

tschie

A few changes needed. I agree with Jon's feedback too. Good work so far!

made changes as per suggestion in pr

JonLavi

This is almost ready @hardikc07, nice work! I'm just suggesting a bit of reordering to the method that creates the FCL, so that it's easier to follow for users. Let me know what you think!

JonLavi · 2020-04-01T08:25:09Z

...sri/samples/feature_collection_layer_from_portal/FeatureCollectionLayerFromPortalSample.java

@@ -16,6 +16,7 @@

 package com.esri.samples.feature_collection_layer_from_portal;

+import com.esri.arcgisruntime.loadable.LoadStatus;


Just make sure to put this import in the right order (with the bloc below).
I can really recommend you set up IntelliJ to order the imports for you, so you won't ever have to worry about it again.

JonLavi · 2020-04-01T08:26:40Z

...sri/samples/feature_collection_layer_from_portal/FeatureCollectionLayerFromPortalSample.java

+            // create portal
+            portal = new Portal("https://www.arcgis.com/");
+
+            // create a map view and set the map to it
            mapView = new MapView();
            mapView.setMap(map);


I'd suggest swapping the order of these two lines. That way we deal with the map and map view first, and then create the portal. It should be a bit easier to follow.

Suggested change

// create portal

portal = new Portal("https://www.arcgis.com/");

// create a map view and set the map to it

mapView = new MapView();

mapView.setMap(map);

// create a map view and set the map to it

mapView = new MapView();

mapView.setMap(map);

// create portal

portal = new Portal("https://www.arcgis.com/");

JonLavi · 2020-04-01T08:29:01Z

...sri/samples/feature_collection_layer_from_portal/FeatureCollectionLayerFromPortalSample.java

+            inputTextField = new TextField();
+            inputTextField.setMaxWidth(250);
+            inputTextField.setText("32798dfad17942858d5eef82ee802f0b");


You could do as Tyler suggested and put the contents of the text field in the constructor:

Suggested change

inputTextField = new TextField();

inputTextField.setMaxWidth(250);

inputTextField.setText("32798dfad17942858d5eef82ee802f0b");

inputTextField = new TextField("32798dfad17942858d5eef82ee802f0b");

inputTextField.setMaxWidth(250);

JonLavi · 2020-04-01T08:30:24Z

...sri/samples/feature_collection_layer_from_portal/FeatureCollectionLayerFromPortalSample.java

-            });
+            inputTextField = new TextField();
+            inputTextField.setMaxWidth(250);
+            inputTextField.setText("32798dfad17942858d5eef82ee802f0b");

            fetchFeatureCollectionFromPortal();


Let's add a small comment here to help the users see what's going on:

Suggested change

fetchFeatureCollectionFromPortal();

// fetch the default feature collection layer from the portal

fetchFeatureCollectionFromPortal();

JonLavi · 2020-04-01T08:31:08Z

...sri/samples/feature_collection_layer_from_portal/FeatureCollectionLayerFromPortalSample.java

+            /**
+             * Action event on button and validation of empty Text Filed
+             */


The comment still appears in JavaDoc style for me. Could you just double check it's in a single line?

JonLavi · 2020-04-01T09:10:46Z

...sri/samples/feature_collection_layer_from_portal/FeatureCollectionLayerFromPortalSample.java

+        else
+        {
+            new Alert(Alert.AlertType.ERROR, "Portal Item ID is empty. Please enter a Portal Item ID.").show();
+        }

    }


Nice work on this! There's only a couple of things left to tidy here:
A bit of whitespace would help make the users read this a little easier. As a general rule of thumb, we try and add a blank line between each block of code.

For the sake of making an easy to follow sample, we'd want to do a few things and consider the order of doing them:

check that the portal item ID is provided

check that we can load the portal item, and that it loaded successfuly (Adding the FCL should only happen after we check that the portal item has done loading successfuly. That way we don't perform the action before the appropriate resource is loaded. )

check that the portal item is a feature collection (We need to check that the portal item is a feature collection before actually trying to use it to create the FCL )

create the feature collection layer

add the later to the map.

This would make it a lot easier for users to read the sample and understand in which order stuff needs to be done.

Keep in mind that we don't generally print out the loading error using portalItem.getLoadError().getCause().toString(), as you've done, because it will be displayed to they end-user, and they wouldn't know what to do with the technical information. Instead we just write a message that describes what went wrong.

Suggested change

}

/**

* Fetch a feature collection from a portal and load it as a feature layer.

*/

private void fetchFeatureCollectionFromPortal() {

if (!inputTextField.getText().isEmpty()) {

// crate portal item

PortalItem portalItem = new PortalItem(portal, inputTextField.getText());

// load the portal item

portalItem.loadAsync();

portalItem.addDoneLoadingListener(() -> {

if (portalItem.getLoadStatus() == LoadStatus.LOADED) {

// check that the portal item is a feature collection

if (portalItem.getType() == PortalItem.Type.FEATURE_COLLECTION) {

// create a feature collection layer

featureCollection = new FeatureCollection(portalItem);

FeatureCollectionLayer featureCollectionLayer = new FeatureCollectionLayer(featureCollection);

// add the feature layer to the map

map.getOperationalLayers().clear();

map.getOperationalLayers().add(featureCollectionLayer);

} else {

new Alert(Alert.AlertType.ERROR, "Portal Item is not a valid Feature Collection.").show();

}

} else {

new Alert(Alert.AlertType.ERROR, "Failed to load Portal Item.").show();

}

});

} else {

new Alert(Alert.AlertType.ERROR, "Portal Item ID is empty. Please enter a Portal Item ID.").show();

}

}

few more changes as per review by jonathan - removed javadoc comment - set text in costructor - import order / map portal oder fixes - validation of portalitem and loading status before creating FC

hardikc07

made changes as suggested

JonLavi

Nice work @hardikc07 !
Only found a typo and a little bit of formatting to fix, but after that I think it's good.

JonLavi · 2020-04-03T14:47:42Z

...sri/samples/feature_collection_layer_from_portal/FeatureCollectionLayerFromPortalSample.java


+            // fetch the default feature collection layer from the portal
            fetchFeatureCollectionFromPortal();

            // create button to perform action
            Button fetchFromProtalButton = new Button("Open from portal item");


There's a typo in the name of the button:
fetchFromPortalButton

JonLavi · 2020-04-03T14:48:14Z

...sri/samples/feature_collection_layer_from_portal/FeatureCollectionLayerFromPortalSample.java

+                }
+            });
+
+        } else
        {


We don't need the newline here between else and {

JonLavi · 2020-04-03T14:48:57Z

...sri/samples/feature_collection_layer_from_portal/FeatureCollectionLayerFromPortalSample.java

-                        }
+            portalItem.loadAsync();
+
+            portalItem.addDoneLoadingListener(()->{


Just a bit of formatting here:

Suggested change

portalItem.addDoneLoadingListener(()->{

portalItem.addDoneLoadingListener(() -> {

- typo in button name - remove extra sapce for else cond - added space in listener method

tschie

Just a few more small things to change. Please mark the feedback as Resolved when you make the updates.

tschie · 2020-04-03T21:14:21Z

feature_layers/feature-collection-layer-from-portal/README.md

+3. Verify that the item represents a feature collection.
+4. Create a `FeatureCollection` from the item.
+5. Create a `FeatureCollectionLayer`, referring to the feature collection.
+6. Add the feature collection layer to the map's `OperationalLayers` collection.


Suggested change

6. Add the feature collection layer to the map's `OperationalLayers` collection.

6. Add the feature collection layer to the map's operational layers collection.

tschie · 2020-04-03T21:15:07Z

feature_layers/feature-collection-layer-from-portal/README.metadata.json

+    "snippets": [
+        "src/main/java/com/esri/samples/feature_collection_layer_from_portal/FeatureCollectionLayerFromPortalSample.java"
+    ],
+    "title": "Feature Collection Layer From Portal"


Suggested change

"title": "Feature Collection Layer From Portal"

"title": "Feature Collection Layer from Portal"

tschie · 2020-04-03T21:17:35Z

...sri/samples/feature_collection_layer_from_portal/FeatureCollectionLayerFromPortalSample.java

+                        new Alert(Alert.AlertType.ERROR, "This is not valid Feature Collection.").show();
+                    }
+                } else {
+                    new Alert(Alert.AlertType.ERROR, "Item does not exist or is inaccessible").show();


Suggested change

new Alert(Alert.AlertType.ERROR, "Item does not exist or is inaccessible").show();

new Alert(Alert.AlertType.ERROR, "Portal item failed to load").show();

tschie · 2020-04-03T21:17:55Z

...sri/samples/feature_collection_layer_from_portal/FeatureCollectionLayerFromPortalSample.java

+                        map.getOperationalLayers().add(featureCollectionLayer);
+
+                        } else {
+                        new Alert(Alert.AlertType.ERROR, "This is not valid Feature Collection.").show();


Suggested change

new Alert(Alert.AlertType.ERROR, "This is not valid Feature Collection.").show();

new Alert(Alert.AlertType.ERROR, "Portal item is not a feature collection").show();

tschie · 2020-04-03T21:18:53Z

...sri/samples/feature_collection_layer_from_portal/FeatureCollectionLayerFromPortalSample.java

+    private MapView mapView;
+    private ArcGISMap map;
+    private Portal portal;
+    private FeatureCollection featureCollection;


This should be a local variable in the fetch method.

tschie · 2020-04-03T21:19:32Z

...sri/samples/feature_collection_layer_from_portal/FeatureCollectionLayerFromPortalSample.java

+            });
+        } else
+        {
+            new Alert(Alert.AlertType.ERROR, "Portal Item ID is empty. Please enter a Portal Item ID.").show();


Suggested change

new Alert(Alert.AlertType.ERROR, "Portal Item ID is empty. Please enter a Portal Item ID.").show();

new Alert(Alert.AlertType.ERROR, "Portal Item ID is empty").show();

- alert message - readme

AVWORLD\hard7971 added 7 commits March 20, 2020 15:55

new sample - feature collection layer sample

d3025ef

Update build.gradle

f041874

changes in build.gradle file

Update settings.gradle

b25cee2

changes in files for sample

853f24a

changes in files

4d43ee2

screenshot added and changes in java files

f088666

Update README.md

0d0e1b8

hardikc07 requested review from tschie and JonLavi March 24, 2020 22:25

JonLavi suggested changes Mar 25, 2020

View reviewed changes

Hardik Shah and others added 4 commits March 26, 2020 11:06

Update feature_layers/feature-collection-layer-from-portal/README.md

4fc8783

Co-Authored-By: Jonathan Lavi <[email protected]>

Update feature_layers/feature-collection-layer-from-portal/README.md

874869c

Co-Authored-By: Jonathan Lavi <[email protected]>

Apply suggestions from code review

35e516f

Co-Authored-By: Jonathan Lavi <[email protected]>

sample changes

cbdc6f9

removed controller file , added code into one java file and also removed fxml/css file

JonLavi self-requested a review March 30, 2020 07:15

JonLavi reviewed Mar 30, 2020

View reviewed changes

Apply suggestions from code review

d748847

making changes as per review by jonathan Co-Authored-By: Jonathan Lavi <[email protected]>

tschie reviewed Mar 30, 2020

View reviewed changes

...sri/samples/feature_collection_layer_from_portal/FeatureCollectionLayerFromPortalSample.java Outdated Show resolved Hide resolved

tschie reviewed Mar 30, 2020

View reviewed changes

...sri/samples/feature_collection_layer_from_portal/FeatureCollectionLayerFromPortalSample.java Outdated Show resolved Hide resolved

tschie reviewed Mar 30, 2020

View reviewed changes

...sri/samples/feature_collection_layer_from_portal/FeatureCollectionLayerFromPortalSample.java Outdated Show resolved Hide resolved

tschie suggested changes Mar 30, 2020

View reviewed changes

changes in 2 files

b456767

made changes as per suggestion in pr

JonLavi reviewed Apr 1, 2020

View reviewed changes

made changes in sample

ac0292d

few more changes as per review by jonathan - removed javadoc comment - set text in costructor - import order / map portal oder fixes - validation of portalitem and loading status before creating FC

hardikc07 commented Apr 3, 2020

View reviewed changes

JonLavi self-requested a review April 3, 2020 10:21

JonLavi approved these changes Apr 3, 2020

View reviewed changes

minor changes

86d3fb5

- typo in button name - remove extra sapce for else cond - added space in listener method

tschie approved these changes Apr 3, 2020

View reviewed changes

done changes tyler suggested

a92a82a

- alert message - readme

hardikc07 merged commit fd3a211 into dev Apr 13, 2020

hardikc07 deleted the fclfp_hardik branch April 13, 2020 18:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fclfp hardik #463

Fclfp hardik #463

hardikc07 commented Mar 24, 2020

JonLavi left a comment

JonLavi Mar 25, 2020

JonLavi Mar 25, 2020

JonLavi Mar 25, 2020

JonLavi Mar 25, 2020

JonLavi Mar 25, 2020

JonLavi left a comment

JonLavi Mar 30, 2020

JonLavi Mar 30, 2020

JonLavi Mar 30, 2020

JonLavi Mar 30, 2020

tschie Mar 30, 2020 •

edited

Loading

tschie Mar 30, 2020

tschie Mar 30, 2020

tschie left a comment

JonLavi left a comment

JonLavi Apr 1, 2020

JonLavi Apr 1, 2020

JonLavi Apr 1, 2020

JonLavi Apr 1, 2020

JonLavi Apr 1, 2020

JonLavi Apr 1, 2020 •

edited

Loading

hardikc07 left a comment

JonLavi left a comment

JonLavi Apr 3, 2020

JonLavi Apr 3, 2020

JonLavi Apr 3, 2020

tschie left a comment •

edited

Loading

tschie Apr 3, 2020

tschie Apr 3, 2020

tschie Apr 3, 2020

tschie Apr 3, 2020

tschie Apr 3, 2020

tschie Apr 3, 2020

		stage.show();


		// create a new ArcGISMap with an oceans Basemap

	// create a new ArcGISMap with an oceans Basemap
	// create a new ArcGISMap with the oceans basemap

	// create a map view and set the ArcGISMap to it
	// create a map view and set the map to it

		@@ -16,6 +16,7 @@

		package com.esri.samples.feature_collection_layer_from_portal;

		import com.esri.arcgisruntime.loadable.LoadStatus;

	fetchFeatureCollectionFromPortal();
	// fetch the default feature collection layer from the portal
	fetchFeatureCollectionFromPortal();

-    }
+    /**
+     * Fetch a feature collection from a portal and load it as a feature layer.
+     */
+    private void fetchFeatureCollectionFromPortal() {
+        if (!inputTextField.getText().isEmpty()) {
+            // crate portal item
+            PortalItem portalItem = new PortalItem(portal, inputTextField.getText());
+            // load the portal item
+            portalItem.loadAsync();
+            portalItem.addDoneLoadingListener(() -> {
+                if (portalItem.getLoadStatus() == LoadStatus.LOADED) {
+                    // check that the portal item is a feature collection
+                    if (portalItem.getType() == PortalItem.Type.FEATURE_COLLECTION) {
+                        // create a feature collection layer
+                        featureCollection = new FeatureCollection(portalItem);
+                        FeatureCollectionLayer featureCollectionLayer = new FeatureCollectionLayer(featureCollection);
+                        // add the feature layer to the map
+                        map.getOperationalLayers().clear();
+                        map.getOperationalLayers().add(featureCollectionLayer);
+                    } else {
+                        new Alert(Alert.AlertType.ERROR, "Portal Item is not a valid Feature Collection.").show();
+                    }
+                } else {
+                    new Alert(Alert.AlertType.ERROR, "Failed to load Portal Item.").show();
+                }
+            });
+        } else {
+            new Alert(Alert.AlertType.ERROR, "Portal Item ID is empty. Please enter a Portal Item ID.").show();
+        }
+    }

+                              }
+                          });
+                      } else
                       {

	portalItem.addDoneLoadingListener(()->{
	portalItem.addDoneLoadingListener(() -> {

	6. Add the feature collection layer to the map's `OperationalLayers` collection.
	6. Add the feature collection layer to the map's operational layers collection.

	"title": "Feature Collection Layer From Portal"
	"title": "Feature Collection Layer from Portal"

	new Alert(Alert.AlertType.ERROR, "Item does not exist or is inaccessible").show();
	new Alert(Alert.AlertType.ERROR, "Portal item failed to load").show();

	new Alert(Alert.AlertType.ERROR, "This is not valid Feature Collection.").show();
	new Alert(Alert.AlertType.ERROR, "Portal item is not a feature collection").show();

Fclfp hardik #463

Fclfp hardik #463

Conversation

hardikc07 commented Mar 24, 2020

JonLavi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JonLavi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tschie Mar 30, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tschie left a comment

Choose a reason for hiding this comment

JonLavi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JonLavi Apr 1, 2020 • edited Loading

Choose a reason for hiding this comment

hardikc07 left a comment

Choose a reason for hiding this comment

JonLavi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tschie left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tschie Mar 30, 2020 •

edited

Loading

JonLavi Apr 1, 2020 •

edited

Loading

tschie left a comment •

edited

Loading