Add dynamic entity layer #139

prupani-7 · 2023-10-16T23:29:44Z

Description

PR to add a new Kotlin sample "Add Dynamic Entity Layer" in Layers category.

Links and Data

Sample Epic: runtime/kotlin/issues/2927

What To Review

Review the code to make sure it is easy to follow like other samples on Android
README.md and README.metadata.json files

How to Test

Run the sample on the sample viewer or the repo.

shubham7109

Nice sample @prupani-7!

samples-lib/src/main/java/com/esri/arcgismaps/sample/sampleslib/components/BottomSheet.kt

add-dynamic-entity-layer/src/main/res/values/strings.xml

...y-layer/src/main/java/com/esri/arcgismaps/sample/adddynamicentitylayer/screens/MainScreen.kt

...rc/main/java/com/esri/arcgismaps/sample/adddynamicentitylayer/components/BottomAppContent.kt

samples-lib/src/main/java/com/esri/arcgismaps/sample/sampleslib/components/ViewshedSlider.kt

.../src/main/java/com/esri/arcgismaps/sample/adddynamicentitylayer/components/ComposeMapView.kt

...er/src/main/java/com/esri/arcgismaps/sample/adddynamicentitylayer/components/MapViewModel.kt

Co-authored-by: Shubham Sharma <[email protected]>

…ple/adddynamicentitylayer/screens/MainScreen.kt Co-authored-by: Shubham Sharma <[email protected]>

…ple/adddynamicentitylayer/components/BottomAppContent.kt Co-authored-by: Shubham Sharma <[email protected]>

…ple/adddynamicentitylayer/components/MapViewModel.kt Co-authored-by: Shubham Sharma <[email protected]>

prupani-7 · 2023-10-20T21:05:15Z

@shubham7109 thanks for the detailed review. Applied you suggestions and added couple comments with my thoughts. Please re-review and let me know if the changes look good to be approved?

shubham7109

Just one final change. Looks good to approve @prupani-7!

shubham7109 · 2023-10-23T19:21:52Z

.../main/java/com/esri/arcgismaps/sample/adddynamicentitylayer/components/BottomSheetContent.kt

+    observationsPerTrack: Float,
+    onDismiss: () -> Unit = { }
+) {
+    var sliderValue by remember { mutableStateOf(observationsPerTrack) }


You could remove this as well, and use observationsPerTrack to set the slider value.

missed removing this earlier. Thanks!

shubham7109 · 2023-10-23T19:23:44Z

.../main/java/com/esri/arcgismaps/sample/adddynamicentitylayer/components/BottomSheetContent.kt

+                            text = sliderValue.toInt().toString()
+                        )
+                    }
+                    Slider(
+                        value = sliderValue,
+                        onValueChange = {
+                            sliderValue = it
+                            onObservationsChanged(sliderValue)


And you could pass in the observationsPerTrack to the slider and Compose would handle observation changes

Suggested change

text = sliderValue.toInt().toString()

)

}

Slider(

value = sliderValue,

onValueChange = {

sliderValue = it

onObservationsChanged(sliderValue)

text = observationsPerTrack.roundToInt().toString()

)

}

Slider(

value = observationsPerTrack,

onValueChange = {

onObservationsChanged(it)

rchintapalli

Couple of doc related issues found

Overall a nice sample to showcase dynamic entities, UI looks nice and clean

rchintapalli · 2023-10-30T15:54:27Z

add-dynamic-entity-layer/README.md

+
+## Use case
+
+A stream service is a type of service provided by ArcGIS Velocity and GeoEvent Server that allows clients to receive a stream of data observations via a web socket. ArcGIS Maps SDK for .NET allows you to connect to a stream service and manage the information as dynamic entities and display them in a dynamic entity layer. Displaying information from feeds such as a stream service is important in applications like dashboards where users need to visualize and track updates of real-world objects in real-time.


Suggested change

A stream service is a type of service provided by ArcGIS Velocity and GeoEvent Server that allows clients to receive a stream of data observations via a web socket. ArcGIS Maps SDK for .NET allows you to connect to a stream service and manage the information as dynamic entities and display them in a dynamic entity layer. Displaying information from feeds such as a stream service is important in applications like dashboards where users need to visualize and track updates of real-world objects in real-time.

A stream service is a type of service provided by ArcGIS Velocity and GeoEvent Server that allows clients to receive a stream of data observations via a web socket. ArcGIS Maps SDK for Kotlin allows you to connect to a stream service and manage the information as dynamic entities and display them in a dynamic entity layer. Displaying information from feeds such as a stream service is important in applications like dashboards where users need to visualize and track updates of real-world objects in real-time.

rchintapalli · 2023-10-30T15:58:32Z

add-dynamic-entity-layer/README.md

+
+## How it works
+
+1. Create an `ArcGIStreamService` using a `Uri`.


In Kotlin we just take Url string. This seems to be dotnet specific

prupani-7 · 2023-10-30T20:27:35Z

Thanks @rchintapalli for suggestions! good catch
Please re-review?

prupani-7 · 2023-10-31T21:48:52Z

Thanks @shubham7109 @rchintapalli for reviews! Merged.

prupani-7 added 6 commits October 13, 2023 16:49

working app

af90030

refactoring, readme, readme metadata, png

ee5934a

style checker

3585e05

style checker

a5aa93f

comments

38010c3

string.xml

543dcea

prupani-7 self-assigned this Oct 17, 2023

shubham7109 requested changes Oct 19, 2023

View reviewed changes

prupani-7 and others added 11 commits October 19, 2023 15:42

Update add-dynamic-entity-layer/src/main/res/values/strings.xml

27b7aab

Co-authored-by: Shubham Sharma <[email protected]>

Update add-dynamic-entity-layer/src/main/java/com/esri/arcgismaps/sam…

2f89be0

…ple/adddynamicentitylayer/screens/MainScreen.kt Co-authored-by: Shubham Sharma <[email protected]>

Update add-dynamic-entity-layer/src/main/java/com/esri/arcgismaps/sam…

bbf354f

…ple/adddynamicentitylayer/screens/MainScreen.kt Co-authored-by: Shubham Sharma <[email protected]>

Update add-dynamic-entity-layer/src/main/java/com/esri/arcgismaps/sam…

dceea7a

…ple/adddynamicentitylayer/components/BottomAppContent.kt Co-authored-by: Shubham Sharma <[email protected]>

Update add-dynamic-entity-layer/src/main/java/com/esri/arcgismaps/sam…

4589813

…ple/adddynamicentitylayer/components/BottomAppContent.kt Co-authored-by: Shubham Sharma <[email protected]>

Update add-dynamic-entity-layer/src/main/java/com/esri/arcgismaps/sam…

97eb9f6

…ple/adddynamicentitylayer/components/BottomAppContent.kt Co-authored-by: Shubham Sharma <[email protected]>

Update add-dynamic-entity-layer/src/main/java/com/esri/arcgismaps/sam…

e8f303d

…ple/adddynamicentitylayer/components/MapViewModel.kt Co-authored-by: Shubham Sharma <[email protected]>

Update add-dynamic-entity-layer/src/main/java/com/esri/arcgismaps/sam…

8629755

…ple/adddynamicentitylayer/components/MapViewModel.kt Co-authored-by: Shubham Sharma <[email protected]>

PR feedback from Shubham

1680058

suggestions

d2d99b7

metadata

51fec79

prupani-7 requested a review from shubham7109 October 20, 2023 21:05

shubham7109 approved these changes Oct 23, 2023

View reviewed changes

handle observationsPerTrack changes

c255d57

shubham7109 added the New sample New Kotlin sample using ArcGIS Maps SDK label Oct 24, 2023

shubham7109 changed the title ~~Pri/add dynamic entity layer~~ Add dynamic entity layer Oct 27, 2023

rchintapalli self-requested a review October 30, 2023 16:07

rchintapalli reviewed Oct 30, 2023

View reviewed changes

update readme

3a845c1

prupani-7 requested a review from rchintapalli October 30, 2023 20:51

rchintapalli approved these changes Oct 31, 2023

View reviewed changes

prupani-7 merged commit 24d6391 into v.next Oct 31, 2023

prupani-7 deleted the pri/add-dynamic-entity-layer branch October 31, 2023 21:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add dynamic entity layer #139

Add dynamic entity layer #139

prupani-7 commented Oct 16, 2023 •

edited

Loading

shubham7109 left a comment

prupani-7 commented Oct 20, 2023

shubham7109 left a comment

shubham7109 Oct 23, 2023

prupani-7 Oct 23, 2023

shubham7109 Oct 23, 2023

rchintapalli left a comment

rchintapalli Oct 30, 2023

rchintapalli Oct 30, 2023

prupani-7 commented Oct 30, 2023

prupani-7 commented Oct 31, 2023


		## Use case

		A stream service is a type of service provided by ArcGIS Velocity and GeoEvent Server that allows clients to receive a stream of data observations via a web socket. ArcGIS Maps SDK for .NET allows you to connect to a stream service and manage the information as dynamic entities and display them in a dynamic entity layer. Displaying information from feeds such as a stream service is important in applications like dashboards where users need to visualize and track updates of real-world objects in real-time.


		## How it works

		1. Create an `ArcGIStreamService` using a `Uri`.

Add dynamic entity layer #139

Add dynamic entity layer #139

Conversation

prupani-7 commented Oct 16, 2023 • edited Loading

Description

Links and Data

What To Review

How to Test

shubham7109 left a comment

Choose a reason for hiding this comment

prupani-7 commented Oct 20, 2023

shubham7109 left a comment

Choose a reason for hiding this comment

shubham7109 Oct 23, 2023

Choose a reason for hiding this comment

prupani-7 Oct 23, 2023

Choose a reason for hiding this comment

shubham7109 Oct 23, 2023

Choose a reason for hiding this comment

rchintapalli left a comment

Choose a reason for hiding this comment

rchintapalli Oct 30, 2023

Choose a reason for hiding this comment

rchintapalli Oct 30, 2023

Choose a reason for hiding this comment

prupani-7 commented Oct 30, 2023

prupani-7 commented Oct 31, 2023

prupani-7 commented Oct 16, 2023 •

edited

Loading