Skip to content

Samples/display map clip geometry #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 20, 2022

Conversation

TADraeseke
Copy link
Collaborator

Ok this PR is probably a bit messy its:

  • Been flattened to do away with the extra kotlin/ level on top
  • your display map is in here
  • I've add clip geometry

Sorry for it being so unclean! Hopefully not too bad to get us started. Future PRs will be much more granular

Copy link
Collaborator

@shubham7109 shubham7109 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't think we should use activityMainBinding too many times for readability, so I made minor changes.

I like the new flattened approach!

@shubham7109 shubham7109 merged commit ad1b67c into main Sep 20, 2022
@shubham7109 shubham7109 deleted the samples/display-map-clip-geometry branch September 20, 2022 01:00
@TADraeseke
Copy link
Collaborator Author

I agree. Nice to not have too many references to activityMainBinding 👍

@shubham7109 shubham7109 added the New sample New Kotlin sample using ArcGIS Maps SDK label Oct 13, 2022
shubham7109 added a commit that referenced this pull request Oct 15, 2024
shubham7109 added a commit that referenced this pull request Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New sample New Kotlin sample using ArcGIS Maps SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants