Skip to content

Fix get sample usage #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2024
Merged

Fix get sample usage #246

merged 1 commit into from
Oct 17, 2024

Conversation

shubham7109
Copy link
Collaborator

Description

PR to fix the get sample usage using the sample title string for the SearchSuggestionsList screen

@shubham7109 shubham7109 self-assigned this Oct 17, 2024
TADraeseke
TADraeseke approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@TADraeseke TADraeseke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I double checked those two get functions were unused in the project and looks like they aren't

@shubham7109 shubham7109 merged commit b17c093 into trev8939/audit Oct 17, 2024
@shubham7109 shubham7109 deleted the shubham/fix-get-sample-usage branch October 17, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TADraeseke TADraeseke TADraeseke approved these changes

Assignees

@shubham7109 shubham7109

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shubham7109 @TADraeseke