-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New sample: Manage features #331
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one bug fix and couple code suggestions:
...rc/main/java/com/esri/arcgismaps/sample/managefeatures/components/ManageFeaturesViewModel.kt
Outdated
Show resolved
Hide resolved
...rc/main/java/com/esri/arcgismaps/sample/managefeatures/components/ManageFeaturesViewModel.kt
Outdated
Show resolved
Hide resolved
Thanks @shubham7109 -- ready for re-review. enum a big improvement, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding in the changes. looks good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work,
LGTM 👍🏼
...rc/main/java/com/esri/arcgismaps/sample/managefeatures/components/ManageFeaturesViewModel.kt
Outdated
Show resolved
Hide resolved
...rc/main/java/com/esri/arcgismaps/sample/managefeatures/components/ManageFeaturesViewModel.kt
Outdated
Show resolved
Hide resolved
...rc/main/java/com/esri/arcgismaps/sample/managefeatures/components/ManageFeaturesViewModel.kt
Show resolved
Hide resolved
...ures/src/main/java/com/esri/arcgismaps/sample/managefeatures/screens/ManageFeaturesScreen.kt
Outdated
Show resolved
Hide resolved
...rc/main/java/com/esri/arcgismaps/sample/managefeatures/components/ManageFeaturesViewModel.kt
Show resolved
Hide resolved
Thanks @eri9000! Merging! |
Description
PR to add a new Kotlin sample Manage features in Edit and manage data category.
Testing: