Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New sample: Manage features #331

Merged
merged 9 commits into from
Mar 19, 2025
Merged

Conversation

TADraeseke
Copy link
Collaborator

@TADraeseke TADraeseke commented Mar 14, 2025

Description

PR to add a new Kotlin sample Manage features in Edit and manage data category.

Testing:

@TADraeseke TADraeseke marked this pull request as ready for review March 14, 2025 17:33
Copy link
Collaborator

@shubham7109 shubham7109 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one bug fix and couple code suggestions:

@shubham7109 shubham7109 added the New sample New Kotlin sample using ArcGIS Maps SDK label Mar 17, 2025
@TADraeseke TADraeseke requested a review from shubham7109 March 18, 2025 19:24
@TADraeseke
Copy link
Collaborator Author

Thanks @shubham7109 -- ready for re-review. enum a big improvement, thanks!

Copy link
Collaborator

@shubham7109 shubham7109 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding in the changes. looks good 👍

@eri9000 eri9000 self-requested a review March 19, 2025 16:26
Copy link
Collaborator

@eri9000 eri9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work,
LGTM 👍🏼

@TADraeseke
Copy link
Collaborator Author

Thanks @eri9000! Merging!

@TADraeseke TADraeseke merged commit 2d0c7de into v.next Mar 19, 2025
1 check failed
@TADraeseke TADraeseke deleted the trev8939/updateFeatureAttributes branch March 19, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New sample New Kotlin sample using ArcGIS Maps SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants