Sample build JSON asset data #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubham7109
changed the title
TADraeseke
requested changes
Mar 18, 2025
There was a problem hiding this comment.
Seems like a really good solution @shubham7109 -- just a couple comments and questions. Thanks!
app/src/main/java/com/esri/arcgismaps/kotlin/sampleviewer/model/Sample.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/esri/arcgismaps/kotlin/sampleviewer/model/DefaultSampleInfoRepository.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/esri/arcgismaps/kotlin/sampleviewer/model/Sample.kt
Show resolved
Hide resolved
|
Thanks for the helpful feedback @TADraeseke. Ready for your review! |
TADraeseke
approved these changes
Mar 19, 2025
colinanderson
approved these changes
Mar 21, 2025
There was a problem hiding this comment.
@shubham7109 I tried this out and it definitely seems to fix the problems 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR to address build files source code misleading android studio. The changes in this PR aims to not use local copied files, but instead maintain a JSON sample asset data with all (100) samples assets in a
sampleAssets/samples.json:{ "sampleA": { "MainActivity.kt": "...content...", "README.md": "...content...", ... }, "sampleB": { ... } }cleanbefore running the changes in this branch.Links and Data
Sample Epic: #5467