Skip to content

SceneView: add ViewLabelProperties #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 20, 2023
Merged

SceneView: add ViewLabelProperties #249

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
75129ea
add viewlabelproperties to sceneview'
hud10837 Dec 18, 2023
45de4b4
fix doc
hud10837 Dec 18, 2023
592ecf2
Merge branch 'feature-branches/geo-compose' of github.com:ArcGIS/arcg…
hud10837 Dec 19, 2023
3b8d9a3
Merge branch 'feature-branches/geo-compose' of github.com:ArcGIS/arcg…
hud10837 Dec 19, 2023
c980720
Merge branch 'feature-branches/geo-compose' into hud10837/scene-view-…
gunt0001 Dec 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions toolkit/geo-compose/src/main/java/com/arcgismaps/toolkit/geocompose/SceneView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ import com.arcgismaps.mapping.view.SceneView
import com.arcgismaps.mapping.view.SingleTapConfirmedEvent
import com.arcgismaps.mapping.view.TwoPointerTapEvent
import com.arcgismaps.mapping.view.UpEvent
import com.arcgismaps.mapping.view.ViewLabelProperties
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.launch

Expand All @@ -51,6 +52,7 @@ import kotlinx.coroutines.launch
* @param viewpointOperation a [SceneViewpointOperation] that changes this SceneView to a new viewpoint
* @param graphicsOverlays the [GraphicsOverlayCollection] used by this composable SceneView
* @param sceneViewProxy the [SceneViewProxy] to associate with the composable SceneView
* @param viewLabelProperties the [ViewLabelProperties] used by the composable SceneView
* @param onInteractingChanged lambda invoked when the user starts and ends interacting with the composable SceneView
* @param onRotate lambda invoked when a user performs a rotation gesture on the composable SceneView
* @param onScale lambda invoked when a user performs a pinch gesture on the composable SceneView
Expand All @@ -70,6 +72,7 @@ public fun SceneView(
viewpointOperation: SceneViewpointOperation? = null,
graphicsOverlays: GraphicsOverlayCollection = rememberGraphicsOverlayCollection(),
sceneViewProxy: SceneViewProxy? = null,
viewLabelProperties: ViewLabelProperties = ViewLabelProperties(),
onInteractingChanged: ((isInteracting: Boolean) -> Unit)? = null,
onRotate: ((RotationChangeEvent) -> Unit)? = null,
onScale: ((ScaleChangeEvent) -> Unit)? = null,
Expand All @@ -90,6 +93,7 @@ public fun SceneView(
factory = { sceneView },
update = {
it.scene = arcGISScene
it.labeling = viewLabelProperties
})

DisposableEffect(Unit) {
Expand Down