Skip to content

add atmosphereEffect #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 9, 2024
Merged

add atmosphereEffect #278

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0cf3f41
add atmosphereEffect
puneet-pdx Jan 9, 2024
b47517b
Merge branch 'feature-branches/geo-compose' into puneet/3300_SceneVie…
puneet-pdx Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion toolkit/geo-compose/src/main/java/com/arcgismaps/toolkit/geocompose/SceneView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ import androidx.compose.ui.viewinterop.AndroidView
import com.arcgismaps.geometry.SpatialReference
import com.arcgismaps.mapping.ArcGISScene
import com.arcgismaps.mapping.TimeExtent
import com.arcgismaps.mapping.view.AtmosphereEffect
import com.arcgismaps.mapping.view.Camera
import com.arcgismaps.mapping.view.CameraController
import com.arcgismaps.mapping.view.DoubleTapEvent
Expand Down Expand Up @@ -69,10 +70,11 @@ import java.time.Instant
* @param selectionProperties the [SelectionProperties] used by the composable SceneView
* @param attributionState specifies the attribution bar's visibility, text changed and layout changed events
* @param cameraController the [CameraController] to manage the position, orientation, and movement of the camera
* @param atmosphereEffect the effect applied to the scene's atmosphere
* @param timeExtent the [TimeExtent] used by the composable SceneView
* @param onTimeExtentChanged lambda invoked when the composable SceneView's [TimeExtent] is changed
* @param sunTime the position of the sun in the scene view based on a specific date and time
* @param sunLighting the type of ambient sunlight and shadows in the scene view
* @param onTimeExtentChanged lambda invoked when the composable SceneView's [TimeExtent] is changed
* @param onNavigationChanged lambda invoked when the navigation status of the composable SceneView has changed
* @param onSpatialReferenceChanged lambda invoked when the spatial reference of the composable SceneView has changed
* @param onLayerViewStateChanged lambda invoked when the composable SceneView's layer view state is changed
Expand Down Expand Up @@ -103,6 +105,7 @@ public fun SceneView(
selectionProperties: SelectionProperties = SelectionProperties(),
attributionState: AttributionState = AttributionState(),
cameraController: CameraController = GlobeCameraController(),
atmosphereEffect: AtmosphereEffect = AtmosphereEffect.HorizonOnly,
timeExtent: TimeExtent? = null,
onTimeExtentChanged: ((TimeExtent?) -> Unit)? = null,
sunTime: Instant = Instant.parse("2000-09-22T12:00:00Z"),
Expand Down Expand Up @@ -137,6 +140,7 @@ public fun SceneView(
it.selectionProperties = selectionProperties
it.setTimeExtent(timeExtent)
it.cameraController = cameraController
it.atmosphereEffect = atmosphereEffect
it.sunTime = sunTime
it.sunLighting = sunLighting
})
Expand Down