Skip to content

Forms: Select Feature #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 19, 2024
Merged

Forms: Select Feature #298

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
848d161
added discard edits api and ui confirmation dialog
kaushikrw Jan 18, 2024
60885c6
fixes issue 369
kaushikrw Jan 18, 2024
d380581
added feature selection
kaushikrw Jan 18, 2024
ae59e6b
Merge branch 'feature-branches/forms' into kaushik/forms/select-feature
kaushikrw Jan 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 32 additions & 35 deletions ...sApp/app/src/main/java/com/arcgismaps/toolkit/featureformsapp/screens/map/MapViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,12 @@ class MapViewModel @Inject constructor(
entry.value.forEach { error ->
featureForm.getFormElement(entry.key)?.let { formElement ->
if (formElement.isEditable.value) {
errors.add(ErrorInfo(formElement.label, error as FeatureFormValidationException))
errors.add(
ErrorInfo(
formElement.label,
error as FeatureFormValidationException
)
)
}
}
}
Expand All @@ -121,7 +126,8 @@ class MapViewModel @Inject constructor(
serviceFeatureTable.serviceGeodatabase?.applyEdits()
?: throw IllegalStateException("cannot apply feature edit without a ServiceGeodatabase")
feature.refresh()
Unit
// unselect the feature after the edits have been saved
(feature.featureTable?.layer as FeatureLayer).clearSelection()
}
// set the state to not editing since the feature was updated successfully
_uiState.value = UIState.NotEditing
Expand Down Expand Up @@ -153,6 +159,8 @@ class MapViewModel @Inject constructor(
fun rollbackEdits(): Result<Unit> {
(_uiState.value as? UIState.Editing)?.let {
it.featureForm.discardEdits()
// unselect the feature
(it.featureForm.feature.featureTable?.layer as FeatureLayer).clearSelection()
_uiState.value = UIState.NotEditing
return Result.success(Unit)
} ?: return Result.failure(IllegalStateException("Not in editing state"))
Expand All @@ -167,41 +175,30 @@ class MapViewModel @Inject constructor(
tolerance = 22.0,
returnPopupsOnly = false
).onSuccess { results ->
results.firstNotNullOfOrNull { result ->
try {
result.geoElements.filterIsInstance<ArcGISFeature>()
.firstOrNull { feature ->
(feature.featureTable?.layer as? FeatureLayer)?.featureFormDefinition != null
}
} catch (e: Exception) {
e.printStackTrace()
Toast.makeText(
context,
"failed to load the FeatureFormDefinition for the feature",
Toast.LENGTH_LONG
).show()
null
}
}?.let { feature ->
feature.load().onSuccess {
try {
val featureForm = FeatureForm(
feature,
(feature.featureTable?.layer as FeatureLayer).featureFormDefinition!!
)
// set the UI to an editing state and set the FeatureForm
try {
results.forEach { result ->
result.geoElements.firstOrNull {
it is ArcGISFeature && (it.featureTable?.layer as? FeatureLayer)?.featureFormDefinition != null
}?.let {
val feature = it as ArcGISFeature
val layer = feature.featureTable!!.layer as FeatureLayer
val featureForm =
FeatureForm(feature, layer.featureFormDefinition!!)
// select the feature
layer.selectFeature(feature)
// set the UI to an editing state with the FeatureForm
_uiState.value = UIState.Editing(featureForm)
} catch (e: Exception) {
e.printStackTrace() // for debugging core issues
Toast.makeText(
context,
"failed to create a FeatureForm for the feature and layer",
Toast.LENGTH_LONG
).show()
}
}.onFailure { println("failed to load tapped Feature") }
} ?: println("identified features do not have feature forms defined")
}.onFailure { println("tap was not on a feature") }
}
} catch (e: Exception) {
e.printStackTrace()
Toast.makeText(
context,
"failed to create a FeatureForm for the feature",
Toast.LENGTH_LONG
).show()
}
}
}
}
}
Expand Down