Forms: fix title padding
#382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorenoid
requested changes
Apr 2, 2024
toolkit/featureforms/src/main/java/com/arcgismaps/toolkit/featureforms/FeatureForm.kt
Outdated
Show resolved
Hide resolved
|
@sorenoid fixed it. Also noticed that the title wasn't using material theme typography which is addressed in this PR. |
sorenoid
approved these changes
Apr 2, 2024
sorenoid
added a commit
that referenced
this pull request
Apr 3, 2024
* provide public webmap which has forms * `Forms`: Updated radio button tests (#366) * updated radio button tests * added test doc link * FeatureForm composable KDoc edit (#368) * slight edits to FeatureForm composable function KDoc. * Update toolkit/featureforms/src/main/java/com/arcgismaps/toolkit/featureforms/FeatureForm.kt Co-authored-by: Gunther Heppner <[email protected]> --------- Co-authored-by: Soren Roth <[email protected]> Co-authored-by: Gunther Heppner <[email protected]> * add groups to final error validation reporting in the app (#367) Co-authored-by: Soren Roth <[email protected]> * `Forms` : Optimize FeatureForm (#369) * agree with exception name change (#377) * update exception name for API change * update exception name for API change * pull in the build of the SDK with the name change of IncorrectValueTypeException --------- Co-authored-by: Soren Roth <[email protected]> * use geo-compose in FeatureFormsApp (#378) * use geo-compose in FeatureFormsApp. * remove DI providing MapViewProxy. add AndroidViewModel usage --------- Co-authored-by: Soren Roth <[email protected]> * `Forms`: do not pass a selected date into date picker if it is out of range. (#376) * do not pass a selected date into date picker if it is out of range. * just expand the year range to incloude out of range field value's date * add an initialError property to the DateTimePickerState, weave it through to the PickerHeader. * use includeTime and adjust spacing. --------- Co-authored-by: Soren Roth <[email protected]> * remove gif. add screenshots (#381) Co-authored-by: Soren Roth <[email protected]> * `Forms`: fix title padding (#382) * swap out public webmap for a managed public webmap (#384) Co-authored-by: Soren Roth <[email protected]> * `Forms` : Update validation behavior for text fields (#385) * fix for breaking API change in dependency (#386) Co-authored-by: Soren Roth <[email protected]> --------- Co-authored-by: Soren Roth <[email protected]> Co-authored-by: Kaushik Meesala <[email protected]> Co-authored-by: Gunther Heppner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FeatureFormTitle.MaterialTheme.typographyforFeatureFormTitle