Skip to content

Forms : Add OAuth login #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 16, 2024
Merged

Conversation

kaushikrw
Copy link
Collaborator

Summary of changes

  • The enterprise login will now use OAuth to sign in.
  • Created an OAuth configuration on the developer dashboard that is linked to the micro app.
  • This OAuth config clientId must be specified in the local.properties file that gets picked up by gradle secrets.

@kaushikrw kaushikrw marked this pull request as ready for review April 15, 2024 20:59
@kaushikrw kaushikrw self-assigned this Apr 15, 2024
@kaushikrw kaushikrw requested a review from sorenoid April 15, 2024 21:00
Copy link
Collaborator

@sorenoid sorenoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great and is really helpful to see other maps!

A default non-functionalvalue for clientId should be placed in secrets.defaults.properties. Other than that I have suggestions but would otherwise approve at this point!

For users we build this app for, i.e. internal testers, it would be good to indicate that oauth is an option on the sign in screen, rather than or in addition to Sign in with ArcGIS Enterprise.

One idea is that if the clientId is present in the BuildConfig and not the default value, another button can be displayed that says Sign in to AGOL with oauth that leads to the same custom chrome tabs experience.

@kaushikrw
Copy link
Collaborator Author

@sorenoid Updated! OAuth will now only work when a client id is provided, otherwise it will use the Username/Password Authentication.

@kaushikrw kaushikrw requested a review from sorenoid April 16, 2024 20:52
Copy link
Collaborator

@sorenoid sorenoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice improvement!

@kaushikrw
Copy link
Collaborator Author

Thanks @sorenoid, merging.

@kaushikrw kaushikrw merged commit 79ee753 into feature-branches/forms Apr 16, 2024
@kaushikrw kaushikrw deleted the kaushik/forms/oauth branch April 16, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants