Forms: Check if map has a FeatureFormDefinition
#399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorenoid
requested changes
Apr 20, 2024
| map.load() | ||
| val layer = map.operationalLayers.firstOrNull { | ||
| if (it is FeatureLayer) { | ||
| it.load() |
There was a problem hiding this comment.
I don't think it is necessary to load the layer here. The featureFormDefinition will be non-null before the layer is loaded if it exists. It could be loaded below in the else case so that only the layer that is needed is loaded explicitly here.
There was a problem hiding this comment.
@sorenoid It seems like the layer needs to be loaded at this time. I can update this when that changes.
sorenoid
approved these changes
Apr 23, 2024
|
thanks @sorenoid |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
FeatureLayers contains aFeatureFormDefinition. If none exists, an alert dialog is shown informing the user.