Skip to content

Forms : View Attachments #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
May 16, 2024

Conversation

kaushikrw
Copy link
Collaborator

@kaushikrw kaushikrw commented May 10, 2024

Summary of changes

  • Added attachment viewer by invoking an intent to display the downloaded attachment via its appropriate file type.
  • Changed the AttachmentFileProvider authority to be unique by prefixing it with the applicationId. With this multiple apps can exist on the same device that use the library.
  • FormAttachmentState is now loadable to include the time taken to save the loaded attachment data to disk.

@kaushikrw kaushikrw self-assigned this May 10, 2024
Base automatically changed from kaushik/forms/delete-rename-attachments to feature-branches/forms May 13, 2024 16:29
@kaushikrw kaushikrw marked this pull request as ready for review May 13, 2024 16:38
@kaushikrw kaushikrw requested a review from sorenoid May 13, 2024 16:38
Copy link
Collaborator

@sorenoid sorenoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have a couple questions

@kaushikrw kaushikrw requested a review from sorenoid May 15, 2024 16:17
@kaushikrw kaushikrw merged commit 5e08263 into feature-branches/forms May 16, 2024
@kaushikrw kaushikrw deleted the kaushik/forms/view-attachments branch May 16, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants