-
Notifications
You must be signed in to change notification settings - Fork 6
Forms
: View Attachments
#422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kaushikrw
merged 30 commits into
feature-branches/forms
from
kaushik/forms/view-attachments
May 16, 2024
Merged
Forms
: View Attachments
#422
kaushikrw
merged 30 commits into
feature-branches/forms
from
kaushik/forms/view-attachments
May 16, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rename-attachments
Base automatically changed from
kaushik/forms/delete-rename-attachments
to
feature-branches/forms
May 13, 2024 16:29
sorenoid
requested changes
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I have a couple questions
...com/arcgismaps/toolkit/featureforms/internal/components/attachment/AttachmentElementState.kt
Outdated
Show resolved
Hide resolved
...com/arcgismaps/toolkit/featureforms/internal/components/attachment/AttachmentElementState.kt
Show resolved
Hide resolved
sorenoid
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
AttachmentFileProvider
authority to be unique by prefixing it with theapplicationId
. With this multiple apps can exist on the same device that use the library.FormAttachmentState
is now loadable to include the time taken to save the loaded attachment data to disk.