Forms : Add attachment fixes
#425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rename-attachments
kaushikrw
changed the base branch from
feature-branches/forms
to
kaushik/forms/view-attachments
sorenoid
requested changes
May 15, 2024
| @@ -80,7 +82,7 @@ internal class AttachmentElementState( | |||
| /** | |||
| * The attachments associated with the form element. | |||
| */ | |||
| val attachments = SnapshotStateList<FormAttachmentState>() | |||
| var attachments by mutableStateOf(emptyMap<Int, FormAttachmentState>()) | |||
There was a problem hiding this comment.
FormAttachments are unique, persistent, and implement equals and hashCode. You can key on them, and if that doesn't work there is likely a bug somewhere.
Suggested change
| var attachments by mutableStateOf(emptyMap<Int, FormAttachmentState>()) | |
| var attachments by mutableStateOf(emptyMap<FormAttachment, FormAttachmentState>()) |
There was a problem hiding this comment.
I believe this should work too, but it the adds a FormAttachment dependency to the AttachmentFormElement. This would mean previews cannot be generated with a list of attachments.
@Composable
AttachmentFormElement(
..
attachments: Map<FormAttachment, FormAttachmentState>,
..
)
sorenoid
approved these changes
May 16, 2024
Base automatically changed from
kaushik/forms/view-attachments
to
feature-branches/forms
May 16, 2024 18:12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Issue
FormAttachmentStatelist is rebuilt after callingfetchAttachmentsand hence any previous UI state is lost.FormAttachmentStateobjects after a call tofetchAttachments.Dialogwhere the state object can be empty.