Skip to content

fixes failing tests #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2024
Merged

fixes failing tests #470

merged 1 commit into from
Jun 20, 2024

Conversation

kaushikrw
Copy link
Collaborator

@kaushikrw kaushikrw commented Jun 17, 2024 •
edited
Loading

Related to issue: #apollo/731

Description: Fixes failing test cases.

Summary of changes:

  • Fixed test test case 6.2, where the ui element being clicked isn't on screen and hence causes the test to fail.
  • Fixed test testPlaceHolderTransformation under ThemingTests, where the focus color of the text field being tested wasn't in focus causing the test to fail.

Pre-merge Checklist

@kaushikrw kaushikrw self-assigned this Jun 17, 2024
@kaushikrw kaushikrw marked this pull request as ready for review June 17, 2024 21:55
@kaushikrw kaushikrw requested a review from sorenoid June 17, 2024 21:55
@kaushikrw kaushikrw merged commit bbdc9f8 into feature-branches/forms Jun 20, 2024
@kaushikrw kaushikrw deleted the kaushik/forms/fix-failing-tests branch June 20, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenoid sorenoid sorenoid approved these changes

Assignees

@kaushikrw kaushikrw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaushikrw @sorenoid