-
Notifications
You must be signed in to change notification settings - Fork 6
Citra update instructions #493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shubham7109 This looks good and the links work.
@shubham7109 Do you have somewhere that tells the developers how to create an API Key and where to use it? |
Thanks @maryharvey! We instruct users to create their own
|
OK understood. The https://developers.arcgis.com/documentation/security-and-authentication/api-key-authentication/ (that you have) takes the dev to the https://developers.arcgis.com/documentation/security-and-authentication/api-key-authentication/tutorials/create-an-api-key/ tutorial. FYI - If you ever wanted to be explicit anywhere in your advice, you could put a link directly to that Tutorial to Create an API Key. |
Thanks @maryharvey Added the relevant doc here: arcgis-maps-sdk-kotlin-toolkit/secrets.defaults.properties Lines 19 to 23 in 462ba39
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion for the doc of the secrets file.
secrets.defaults.properties
Outdated
# Place default values for secrets needed at runtime here. | ||
# Place real secrets in local.properties this file is committed to git. | ||
# suppress inspection "UnusedProperty" for the whole file | ||
# Go to https://links.esri.com/create-an-api-key to obtain a new API key access token. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is worth to add more explanation here:
# Place default values for secrets needed at runtime here. | |
# Place real secrets in local.properties this file is committed to git. | |
# suppress inspection "UnusedProperty" for the whole file | |
# Go to https://links.esri.com/create-an-api-key to obtain a new API key access token. | |
# This properties file contains default values for runtime secrets. | |
# Actual secrets should be placed in `local.properties` to avoid committing sensitive information. | |
# This file is tracked by git; `local.properties` is not. | |
# | |
# For a new API key, visit: https://links.esri.com/create-an-api-key | |
# |
Description
PR to update API key instructions to point to the new developer Create an API Key page.
Links and Data
Issue:
kotlin/issues/3981