Add targetSdk to library modules in the testOptions #516
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue: https://devtopia.esri.com/runtime/kotlin/issues/4231
Description:
Tests are failing due to a popup window that says the app was built for an older version of Android. This has to do with some changes that were introduced by https://issuetracker.google.com/issues/230625468. They deprecated
targetSdk
for library modules, but when the test app is spun up, it doesn't have atargetSdk
and seems to default tominSdk
. As a fix, you can now supplytargetSdk
totestOptions
, so I've done that in every library gradle file, as well as adding it into thelint
blocks for good measure as that was suggested in the google issue.Summary of changes:
targetSdk
to library modulestestOptions
blocks.FLAG_ACTIVITY_NEW_TASK
, which was causing an error and making two tests fail.Pre-merge Checklist