Skip to content

Disable UsernamePassword Login button when fields are empty #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 24, 2024
Merged

Disable UsernamePassword Login button when fields are empty #523

merged 5 commits into from
Jul 24, 2024

Conversation

eri9000
Copy link
Collaborator

@eri9000 eri9000 commented Jul 19, 2024 •
edited
Loading

Related to issue: #

Description:

  • Improvements to the Username/Login prompt

Summary of changes:

  • Disables the "Login" button when the text is empty
  • Disallows submitting empty username/password with keyboard action button
  • Adds test to verify behavior

Pre-merge Checklist

@eri9000 eri9000 changed the title Disable login when fields are empty Disable UsernamePassword Login button when fields are empty Jul 19, 2024
@eri9000 eri9000 marked this pull request as ready for review July 19, 2024 19:16
@eri9000 eri9000 self-assigned this Jul 19, 2024
@XuemingRocks XuemingRocks self-requested a review July 19, 2024 22:13
XuemingRocks
XuemingRocks reviewed Jul 19, 2024
View reviewed changes
Copy link
Collaborator

@XuemingRocks XuemingRocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. However, I can still repro with the following workflow:

  1. Input username
  2. Tap on password field. The Send button at the bottom right corner of the keyboard is enabled.
  3. Tap on the Send button.
    image

@eri9000
Copy link
Collaborator Author

eri9000 commented Jul 19, 2024

@XuemingRocks Good catch, I have pushed a fix for that. Have another look.

XuemingRocks
XuemingRocks approved these changes Jul 20, 2024
View reviewed changes
Copy link
Collaborator

@XuemingRocks XuemingRocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

hud10837
hud10837 reviewed Jul 22, 2024
View reviewed changes
Copy link
Collaborator

@hud10837 hud10837 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change, just a few thoughts.

@eri9000 eri9000 requested review from hud10837 and gunt0001 July 23, 2024 22:33
gunt0001
gunt0001 approved these changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@gunt0001 gunt0001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eri9000 - great test coverage enhancements 👍

hud10837
hud10837 approved these changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@hud10837 hud10837 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@eri9000 eri9000 merged commit 7e65b75 into v.next Jul 24, 2024
@eri9000 eri9000 deleted the Erick/AuthenticatorImprovement branch July 24, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuemingRocks XuemingRocks XuemingRocks approved these changes

@gunt0001 gunt0001 gunt0001 approved these changes

@hud10837 hud10837 hud10837 approved these changes

Assignees

@eri9000 eri9000

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eri9000 @XuemingRocks @gunt0001 @hud10837