Skip to content

remove creds from test #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

sorenoid
Copy link
Collaborator

@sorenoid sorenoid commented Aug 4, 2023

drive the UI tests from JSON so we can remove credentials from test and not depend on secrets.

@sorenoid sorenoid requested a review from kaushikrw August 4, 2023 01:41
Copy link
Collaborator

@kaushikrw kaushikrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sorenoid sorenoid merged commit 59eac24 into feature-branches/forms Aug 7, 2023
@sorenoid sorenoid deleted the sor10874/remove-creds-from-test branch August 7, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants