Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some examples don't seem to belong in the geoview category #992

Open
rolson opened this issue Dec 28, 2024 · 12 comments
Open

Some examples don't seem to belong in the geoview category #992

rolson opened this issue Dec 28, 2024 · 12 comments
Labels
Effort - small A low level of effort to complete enhancement New feature or request v-200.7 Issues for the v200.7 release

Comments

@rolson
Copy link
Contributor

rolson commented Dec 28, 2024

Looking at this list, some of these do not seem to really belong in the "GeoView" category. Possible candidates for moving into a different category:

  • Feature Form
  • Popup
image
@rolson rolson changed the title Some xxamples don't seem to belong in the geoview category Some examples don't seem to belong in the geoview category Dec 28, 2024
@mhdostal mhdostal added enhancement New feature or request Effort - small A low level of effort to complete v-200.7 Issues for the v200.7 release labels Dec 30, 2024
@dfeinzimer
Copy link
Collaborator

What would a suggested category name for Feature Form and Popup be?

Stepping back I'm wondering if the components are distinct enough that we do away with the categories and list all the examples alphabetically from the home view? I think the one exception would be Augmented Reality - we'd probably still want that to navigate to a sub-menu with the three AR types.

@rolson
Copy link
Contributor Author

rolson commented Mar 28, 2025

Stepping back I'm wondering if the components are distinct enough that we do away with the categories and list all the examples alphabetically from the home view? I think the one exception would be Augmented Reality - we'd probably still want that to navigate to a sub-menu with the three AR types.

I like that idea.

@philium
Copy link
Contributor

philium commented Mar 28, 2025

list all the examples alphabetically from the home view

That would make for a long list and more scrolling. Keeping them grouped in some way (not necessarily the existing categories) helps with that and generally makes examples easier to find.

@rolson
Copy link
Contributor Author

rolson commented Mar 28, 2025

With only a dozen or so components, and given the fact that we release very few a year, I think we can categorize further later. It's worth looking at what @dfeinzimer's idea looks like.

@dfeinzimer
Copy link
Collaborator

Here is a category approach I was able to come up with.

  • Accessories
    • Compass
    • Location Button (* future)
    • Overview Map
    • Scalebar
  • Augmented Reality
    • Flyover
    • Tabletop
    • World Scale
  • Data
    • Basemap Gallery
    • Bookmarks
    • Feature Form
    • Feature Template Picker (* future)
    • Floor Filter
    • Popup
    • Search
    • UtilityNetworkTrace
  • Other
    • Floating Panel

@rolson
Copy link
Contributor Author

rolson commented Mar 28, 2025

I like that too. I think FloorFilter could go in Accessories

@dfeinzimer
Copy link
Collaborator

dfeinzimer commented Mar 28, 2025

This is how the top-level approach would look on iPhone 16:

I think FloorFilter could go in Accessories

My approach with the Accessories category is that those would be agnostic to any map or scene and those in the Data category rely on specific data (e.g. a FloorManager, as the FloorFilter does).

@rolson
Copy link
Contributor Author

rolson commented Mar 28, 2025

Either approach works for me. Maybe ask @dg0yal.

@mhdostal
Copy link
Member

That would make for a long list and more scrolling. Keeping them grouped in some way (not necessarily the existing categories) helps with that and generally makes examples easier to find.

Agreed. I'm OK with the grouping @dfeinzimer proposes.

@rolson
Copy link
Contributor Author

rolson commented Mar 31, 2025

That would make for a long list and more scrolling. Keeping them grouped in some way (not necessarily the existing categories) helps with that and generally makes examples easier to find.

Agreed. I'm OK with the grouping @dfeinzimer proposes.

I think Phil wrote that when he thought it was the Swift Examples app, not the toolkit examples.

@dfeinzimer dfeinzimer linked a pull request Mar 31, 2025 that will close this issue
@dfeinzimer
Copy link
Collaborator

@dg0yal, do you have a preference for any of these approaches?

@dg0yal
Copy link
Member

dg0yal commented Apr 7, 2025

I think an alphabetical flat list is fine. We don't have that many components

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Effort - small A low level of effort to complete enhancement New feature or request v-200.7 Issues for the v200.7 release
Projects
None yet
5 participants