Skip to content

Various Examples app fixes and improvements #1135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 30 commits into from
Apr 10, 2025
Merged

Various Examples app fixes and improvements #1135

merged 30 commits into from
Apr 10, 2025

Conversation

dfeinzimer
Copy link
Collaborator

@dfeinzimer dfeinzimer commented Apr 7, 2025 •
edited
Loading

Closes #992

@dfeinzimer dfeinzimer self-assigned this Apr 7, 2025
@dfeinzimer dfeinzimer marked this pull request as ready for review April 7, 2025 23:46
@dfeinzimer dfeinzimer requested review from philium and mhdostal April 7, 2025 23:46
This was referenced Apr 7, 2025
Closed
Closed
@dfeinzimer dfeinzimer linked an issue Apr 7, 2025 that may be closed by this pull request
Example content evaluated twice on the second open on iPhone #1129
Closed
philium
philium reviewed Apr 8, 2025
View reviewed changes
@dfeinzimer dfeinzimer removed a link to an issue Apr 8, 2025
Example content evaluated twice on the second open on iPhone #1129
Closed
@dfeinzimer dfeinzimer requested a review from philium April 8, 2025 22:23
@dfeinzimer
Copy link
Collaborator Author

Ready for review

mhdostal
mhdostal reviewed Apr 10, 2025
View reviewed changes
Copy link
Member

@mhdostal mhdostal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. The only change I would make is to hide the sidebar when an example is selected. I added the code, if you want to try it.

@dfeinzimer dfeinzimer requested a review from mhdostal April 10, 2025 18:29
@dfeinzimer
Copy link
Collaborator Author

Ready for review again, the column is now conditionally hidden.

mhdostal
mhdostal previously approved these changes Apr 10, 2025
View reviewed changes
philium
philium reviewed Apr 10, 2025
View reviewed changes
mhdostal
mhdostal previously approved these changes Apr 10, 2025
View reviewed changes
@dfeinzimer dfeinzimer requested a review from philium April 10, 2025 21:08
mhdostal
mhdostal previously approved these changes Apr 10, 2025
View reviewed changes
@dfeinzimer @philium
CR: Phil
a8b1d94 
Co-Authored-By: Philip Ridgeway <[email protected]>
@dfeinzimer dfeinzimer requested a review from philium April 10, 2025 21:55
@dfeinzimer dfeinzimer requested a review from mhdostal April 10, 2025 21:58
@dfeinzimer dfeinzimer merged commit b82a2d6 into v.next Apr 10, 2025
@dfeinzimer dfeinzimer deleted the df/992/a branch April 10, 2025 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philium philium philium approved these changes

@mhdostal mhdostal mhdostal approved these changes

Assignees

@dfeinzimer dfeinzimer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dfeinzimer @philium @mhdostal