Skip to content

Floor Filter - Two close buttons can appear #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dfeinzimer opened this issue Jan 9, 2023 · 1 comment
Closed

Floor Filter - Two close buttons can appear #244

dfeinzimer opened this issue Jan 9, 2023 · 1 comment
Assignees
@dfeinzimer
Labels
bug Something isn't working Priority - high A high-priority item

Comments

@dfeinzimer
Copy link
Collaborator

The Swift Samples app uses the Floor Filter component with data that appears to cause two close buttons to appear.

Screenshot 2023-01-09 at 11 59 54
@dfeinzimer dfeinzimer added the bug Something isn't working label Jan 9, 2023
@dfeinzimer dfeinzimer mentioned this issue Jan 9, 2023
Merged
@philium
Copy link
Contributor

philium commented Jan 9, 2023

The problem appears to be that both FacilitiesList and its parent (SitesList) have a modifier for the close button. It should only be on one of them.

dfeinzimer added a commit that referenced this issue Feb 18, 2023
@dfeinzimer
Unify location of toolbar close button
3903a63 
Resolves #244
dfeinzimer added a commit that referenced this issue Feb 18, 2023
@dfeinzimer
Apply close buttons in any navigation links
c8eef86 
Addresses #244
@dfeinzimer dfeinzimer mentioned this issue Feb 21, 2023
Merged
@mhdostal mhdostal added the Priority - high A high-priority item label Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dfeinzimer dfeinzimer

Labels
bug Something isn't working Priority - high A high-priority item
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@philium @mhdostal @dfeinzimer