Skip to content

Add UI Test Runner target to the Examples app #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from

Conversation

dfeinzimer
Copy link
Collaborator

@dfeinzimer dfeinzimer commented Jul 11, 2023

Related #362, Apollo 47

This PR serves as an alternative to #364.

#364 creates an entire new testing app with a UI testing target. While writing the starter tests within, I noticed that the test views weren't requiring any differences from the example views we've already written in the Examples app. For that reason, I've opened this PR which simply adds a UI testing target to the existing examples app.

@dfeinzimer dfeinzimer requested a review from mhdostal July 11, 2023 19:08
@dfeinzimer dfeinzimer self-assigned this Jul 11, 2023
@mhdostal
Copy link
Member

This is certainly cleaner and more convenient than the original PR. However, I'm wondering if we're not trying to solve two separate issues now with the Examples. They are mainly to showcase the component and demonstrate how to use it. Two somewhat related things:

  • Are the examples, as they're defined, enough to fully test the component? Meaning, is there component functionality that we'd want to test which is not exposed by the example?

  • Given that the examples are for showcasing/demonstrating the component, I don't want to start "cluttering" them in order to get more test coverage.

Thoughts?

@rolson
Copy link
Contributor

rolson commented Jul 11, 2023

Are the examples, as they're defined, enough to fully test the component?

No.

Given that the examples are for showcasing/demonstrating the component, I don't want to start "cluttering" them in order to get more test coverage.

I strongly agree.

The two goals should not be conflated. Tests are tests, examples are to show the minimum code required to use a component. I don't see these goals as compatible.

@dfeinzimer
Copy link
Collaborator Author

It's a good point and yes I can see this as an issue. When we go to write tests for the Form component we may want to use a number of different forms with differing fields and configurations.

@mhdostal
Copy link
Member

@rolson Thanks for the comments, I think we should keep the two separate, examples and tests. Yes, for the simpler components the test view and example view may be very similar, but for more complex components they will diverge quite a bit.

@dfeinzimer
Copy link
Collaborator Author

Closing in favor of #364

@dfeinzimer dfeinzimer closed this Jul 12, 2023
@dfeinzimer dfeinzimer deleted the df/uiTestRunner2 branch August 9, 2023 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants