Skip to content

Add UI Testing App with UI Test Target + 3 starter tests #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 41 commits into from
Jul 17, 2023

Conversation

dfeinzimer
Copy link
Collaborator

@dfeinzimer dfeinzimer commented Jun 30, 2023

Related #362, Apollo 47

  • Adds a UI Testing App with a UI Test Target and 3 starter tests:
    • Basemap Gallery general usage test
      • Opens the Basemap Gallery and selects two of the available basemaps. Selects a third incompatible basemap and verifies that an error message is shown.
    • Bookmarks general usage test
      • Opens the bookmark picker and verifies the expected bookmarks are present and that Bookmarks.onSelectionChanged(perform:) works as expected.
    • Floor Filter test
      • Selects a site, facility, changes the selected level and collapses the picker

@dfeinzimer dfeinzimer self-assigned this Jun 30, 2023
@dfeinzimer dfeinzimer marked this pull request as ready for review July 6, 2023 18:31
@dfeinzimer dfeinzimer requested a review from mhdostal July 6, 2023 18:31
@dfeinzimer dfeinzimer changed the title Add Toolkit UI testing framework Add Toolkit UI Test Runner Jul 6, 2023
@dfeinzimer dfeinzimer marked this pull request as draft July 8, 2023 00:00
@dfeinzimer dfeinzimer changed the title Add Toolkit UI Test Runner Add UI Testing App with UI Test Target + 3 starter tests Jul 12, 2023
@dfeinzimer dfeinzimer marked this pull request as ready for review July 12, 2023 02:32
@dfeinzimer dfeinzimer requested review from philium and mhdostal July 12, 2023 17:29
mhdostal
mhdostal previously approved these changes Jul 12, 2023
Copy link
Member

@mhdostal mhdostal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@philium
Copy link
Contributor

philium commented Jul 12, 2023

Also, FYI: FloorFilterTests passes on Mac Catalyst, but the other two don't.

@dfeinzimer
Copy link
Collaborator Author

Also, FYI: FloorFilterTests passes on Mac Catalyst, but the other two don't.

I was able to fix the bookmarks tests for Catalyst but the basemap tests are still giving some troubles that I'll need to find a workaround for.

@dfeinzimer
Copy link
Collaborator Author

dfeinzimer commented Jul 14, 2023

I'll need to find a workaround for.

Still not able to figure out why the test isn't able to find the button in Catalyst. The name I'm calling it with is a direct match in Accessibility Inspector. Any ideas I might try?

Screenshot 2023-07-13 at 19 07 41 Screenshot 2023-07-13 at 19 07 34 Screenshot 2023-07-13 at 19 11 01

@dfeinzimer dfeinzimer requested review from philium and mhdostal July 14, 2023 02:11
@philium
Copy link
Contributor

philium commented Jul 14, 2023

Have you tried recording yourself performing the test and comparing the recording with what you have?

mhdostal
mhdostal previously approved these changes Jul 14, 2023
Copy link
Member

@mhdostal mhdostal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, once the mac catalyst tests are OK.

@dfeinzimer
Copy link
Collaborator Author

Have you tried recording yourself performing the test and comparing the recording with what you have?

Yes, the recorder logs this error when tapping the button:

UI Test Runner[60459:740065] [API] cannot add handler to 3 from 3 - dropping

@dfeinzimer
Copy link
Collaborator Author

All tests pass for me across Catalyst and iOS now. Catalyst just needed a longer wait period in the Basemap Gallery test.

@dfeinzimer dfeinzimer requested a review from philium July 17, 2023 17:24
@dfeinzimer dfeinzimer merged commit b16fda2 into v.next Jul 17, 2023
@dfeinzimer dfeinzimer deleted the df/uiTestRunner branch July 17, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants