Update Example groupings #1123
Closed
Update Example groupings #1123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfeinzimer
commented
Mar 31, 2025
| /// Components that can be used with any geoview. | ||
| static var accessories: Self { | ||
| .init( | ||
| name: "Accessories", |
There was a problem hiding this comment.
Would "Basic" be a better name?
| .init( | ||
| name: "GeoView", | ||
| name: "Data", |
There was a problem hiding this comment.
Would "Advanced", "Specialty", or "Specialized" be better for this category?
| .init( | ||
| name: "Accessories", | ||
| examples: [ | ||
| Example("Basemap Gallery", content: BasemapGalleryExampleView()), |
There was a problem hiding this comment.
I moved Basemap Gallery into this category since my original proposal since it can be initialized without specific data on any geoview.
mhdostal
approved these changes
Mar 31, 2025
| /// Components that can be used with any geoview. | ||
| static var accessories: Self { | ||
| .init( | ||
| name: "Accessories", |
rolson
reviewed
Mar 31, 2025
|
Closing in favor of #1135 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #992