-
Notifications
You must be signed in to change notification settings - Fork 11
Add visionOS support to UtilityNetworkTrace
#1011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add visionOS support to UtilityNetworkTrace
#1011
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some feedback:
-
This can be removed for visionOS so the button has a default circle around it.
-
In the example file, the
UtilityNetworkTrace
could use a bit of top padding since it is cramped on the top of the floating panel -
The "Cancel Starting Point Selection" is a bit of an eye sore and should look like this. Where the background of the button is red and the text is white.
-
Under "Advanced Options", it isn't clear the "Name" row is selectable to type in text. So adding a hover effect to the
TextField
there could probably help.
The dialogue is created using the built-in confirmation dialog and the delete button has a destructive role. While it may look odd compared to other buttons, it matches other system confirmation dialogues, such as this one: |
edd8f70
to
4e4c568
Compare
I suspect that the lists aren't styled as grouped because the list is not the root of the view in the navigation stack. |
Should we try that? Or do you think that would require too many changes? |
Please remove |
I am helping Phil finish these PRs while he is out on vacation, can you review this? Thank you. |
I created an issue to come back to this. |
Fixed merge conflict, please re-review. |
No description provided.