Popup View - Collapsable elements #147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…floating panel, and some minor floating panel enhancements.
|
@dfeinzimer There are actually very few changes to FloatingPanel.swift; most of the changes are spacing changes because I added a |
|
Hide the whitespace for easier review:
|
dfeinzimer
reviewed
Sep 19, 2022
|
|
||
| DisclosureGroup(isExpanded: $isExpanded) { | ||
| Divider() | ||
| .padding(.bottom, 4) | ||
| switch popupElement.displayType { |
There was a problem hiding this comment.
Do you get this warning too?
Sources/ArcGISToolkit/Components/FloatingPanel/FloatingPanel.swift
Outdated
Show resolved
Hide resolved
Sources/ArcGISToolkit/Components/Popups/MediaPopupElementView.swift
Outdated
Show resolved
Hide resolved
|
I checked the trace component and didn't find any breaking changes. |
Co-authored-by: David Feinzimer <[email protected]>
…wift Co-authored-by: David Feinzimer <[email protected]>
|
@dfeinzimer Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for collapsable popup elements. It also adjusts the positions of some of the dividers, so there is an always-visible divider between the popup title and the scrollable list of elements. It also adds a "close" button to the popup (not represented in all the screen shots below).
Collapsable screen shots: