Skip to content

Fix Tests #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2022
Merged

Fix Tests #208

merged 1 commit into from
Dec 9, 2022

Conversation

mhdostal
Copy link
Member

@mhdostal mhdostal commented Dec 8, 2022

This fixes three issues with the tests:

  • compile issue with ArcGISToolkitTests/Test Support/Utility/ChallengeHandler.swift; the compile error was Module 'ArcGIS' was not compiled for testing; removing the @testable attribute fixes the error.
  • BasemapGalleryItem test failed as the name of the baseman changed
  • BasemapGalleryItem test failed as the description of the baseman changed; since this is just a huge HTML string, I changed it to just check it's not nil.

@mhdostal mhdostal marked this pull request as ready for review December 8, 2022 17:39
@mhdostal
Copy link
Member Author

mhdostal commented Dec 8, 2022

@njarecha Just wanted to make sure the ChallengeHandler change was OK.

dfeinzimer
dfeinzimer approved these changes Dec 8, 2022
View reviewed changes
Copy link
Collaborator

@dfeinzimer dfeinzimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests build and all pass

@mhdostal mhdostal merged commit 331cc68 into v.next Dec 9, 2022
@mhdostal mhdostal deleted the mhd/FixTests branch December 9, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njarecha njarecha njarecha approved these changes

@dfeinzimer dfeinzimer dfeinzimer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mhdostal @njarecha @dfeinzimer