Skip to content

updated authenticator and doc #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Feb 16, 2023
Merged

updated authenticator and doc #259

merged 10 commits into from
Feb 16, 2023

Conversation

njarecha
Copy link
Contributor

@rolson While writing up doc realized adding setupAuthenticationChallengeHandlers function will be helpful. Also fixed minor doc issues.

@njarecha njarecha requested review from rolson and mhdostal February 10, 2023 21:55
@njarecha njarecha self-assigned this Feb 10, 2023
mhdostal
mhdostal previously approved these changes Feb 10, 2023
View reviewed changes
@njarecha njarecha requested a review from rolson February 11, 2023 00:00
mhdostal
mhdostal previously approved these changes Feb 11, 2023
View reviewed changes
@njarecha
Copy link
Contributor Author

njarecha commented Feb 11, 2023 •
edited
Loading

Please hold on reviewing this PR. I realized something needs to be corrected in the last commit as well as thinking about making some more changes.

@njarecha
Merge branch 'v.next' into njarecha/authenticator-changes
811f13e 
# Conflicts:
#	Tests/ArcGISToolkitTests/Test Support/Extensions/XCTest/XCTestCase+ArcGISURLSession.swift
#	Tests/ArcGISToolkitTests/Test Support/Utility/ChallengeHandler.swift
#	Tests/ArcGISToolkitTests/UtilityNetworkTraceViewModelTests.swift
@njarecha njarecha requested a review from mhdostal February 14, 2023 18:19
@njarecha
Copy link
Contributor Author

@rolson @mhdostal This is ready for re-review. Thank you.

mhdostal
mhdostal reviewed Feb 15, 2023
View reviewed changes
Copy link
Member

@mhdostal mhdostal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just couple of doc items.

@njarecha njarecha requested a review from mhdostal February 15, 2023 19:52
@njarecha njarecha requested a review from rolson February 16, 2023 17:54
rolson
rolson reviewed Feb 16, 2023
View reviewed changes
Copy link
Contributor

@rolson rolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't mean to approve, I had one question

rolson
rolson requested changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@rolson rolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one question

@njarecha njarecha requested a review from rolson February 16, 2023 18:38
@njarecha
Copy link
Contributor Author

Thanks @rolson, @mhdostal, and @philium!

@njarecha njarecha merged commit 1f303be into v.next Feb 16, 2023
@njarecha njarecha deleted the njarecha/authenticator-changes branch February 16, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philium philium philium left review comments

@rolson rolson rolson approved these changes

@mhdostal mhdostal mhdostal approved these changes

Assignees

@njarecha njarecha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@njarecha @philium @rolson @mhdostal