Skip to content

Release updates #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 18, 2023
Merged

Release updates #311

merged 7 commits into from
Apr 18, 2023

Conversation

mhdostal
Copy link
Member

This PR includes updates for the 200.1.0 release, including:

  • Updating copyright dates in the License file
  • Updating Example an Authenticator Example app versions to 200.1.0
  • Updating Package.swift file to reference SDK v200.1.0
  • Changing iOS to Swift in Toolkit description.

@mhdostal mhdostal requested review from dfeinzimer and yo1995 April 18, 2023 15:26
yo1995
yo1995 reviewed Apr 18, 2023
View reviewed changes
Copy link
Contributor

@yo1995 yo1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README.md
@@ -2,7 +2,7 @@

[![doc](https://img.shields.io/badge/Doc-purple)](Documentation) [![SPM](https://img.shields.io/badge/SPM-compatible-4BC51D.svg?style=flat)](https://github.com/apple/swift-package-manager/)

The ArcGIS Maps SDK for Swift Toolkit contains components that will simplify your iOS app development. It is built off of the new ArcGIS Maps SDK for Swift.
The ArcGIS Maps SDK for Swift Toolkit contains components that will simplify your Swift app development. It is built off of the new ArcGIS Maps SDK for Swift.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this needs to be changed… 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The doc team made the change in the online doc, so I'm just duplicating that change.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here it says "that will help simplify your iOS app development"

https://developers.arcgis.com/swift/#open-source-toolkit (next site as well)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm referring to the section description on the landing page, not the toolkit specific page. But I don't think it is a big deal in case you want to change them all to "Swift app development".

@mhdostal mhdostal requested a review from yo1995 April 18, 2023 17:06
yo1995
yo1995 approved these changes Apr 18, 2023
View reviewed changes
README.md
@@ -2,7 +2,7 @@

[![doc](https://img.shields.io/badge/Doc-purple)](Documentation) [![SPM](https://img.shields.io/badge/SPM-compatible-4BC51D.svg?style=flat)](https://github.com/apple/swift-package-manager/)

The ArcGIS Maps SDK for Swift Toolkit contains components that will simplify your iOS app development. It is built off of the new ArcGIS Maps SDK for Swift.
The ArcGIS Maps SDK for Swift Toolkit contains components that will simplify your Swift app development. It is built off of the new ArcGIS Maps SDK for Swift.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here it says "that will help simplify your iOS app development"

https://developers.arcgis.com/swift/#open-source-toolkit (next site as well)

@dfeinzimer
Copy link
Collaborator

Here it says "that will help simplify your iOS app development" https://developers.arcgis.com/swift/#open-source-toolkit (next site as well)

@yo1995 I'm seeing "Swift" on next.

@mhdostal mhdostal merged commit e560106 into v.next Apr 18, 2023
@mhdostal mhdostal deleted the mhd/ReleaseStuff branch April 18, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yo1995 yo1995 yo1995 approved these changes

@dfeinzimer dfeinzimer dfeinzimer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mhdostal @dfeinzimer @yo1995