Skip to content

Repair FloatingPanel bottom content padding #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Conversation

dfeinzimer
Copy link
Collaborator

@dfeinzimer dfeinzimer commented Aug 14, 2023

This replaces a line that was erroneously removed in #380. Without it, content towards the bottom of the FloatingPanel can collide with the Home Bar or the panel's handle divider.

First reported by @des12437 during release testing

HomeBar Panel Handle Divider
Padding homebar divider
No Padding Screenshot 2023-08-14 at 09 07 03 Screenshot 2023-08-14 at 09 07 27

@dfeinzimer dfeinzimer changed the title Repair FloatingPanel bottom content padding Repair FloatingPanel bottom content padding Aug 14, 2023
Copy link
Contributor

@des12437 des12437 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Is there a case where the padding should be zero based on the previous implementation?

 .padding(.bottom, isPresented.wrappedValue ? (isCompact ? 25 : 10) : .zero)

@dfeinzimer
Copy link
Collaborator Author

Looks good. Is there a case where the padding should be zero based on the previous implementation?

Good question, I had considered that and I don't believe taking isPresented into account is needed.

@dfeinzimer dfeinzimer merged commit d1f4bf9 into v.next Aug 14, 2023
@dfeinzimer dfeinzimer deleted the df/fpcontentpadding branch August 14, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants