Skip to content

BasemapGallery test fix #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 14, 2023
Merged

BasemapGallery test fix #395

merged 1 commit into from
Aug 14, 2023

Conversation

mhdostal
Copy link
Member

Fixes the "init" test in response to changes in #328

@mhdostal mhdostal requested a review from dfeinzimer August 14, 2023 16:42
dfeinzimer
dfeinzimer reviewed Aug 14, 2023
View reviewed changes
Copy link
Collaborator

@dfeinzimer dfeinzimer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test passes but then a few moments later I get a crash in core in response handling, still looking.

Update: Haven't found anything out of the ordinary. I get the crash each time with my standard API key.

@mhdostal
Copy link
Member Author

The test passes but then a few moments later I get a crash in core in response handling, still looking.

Weird. I was running all the tests and I didn't get a crash. If I run just the BasemapGallery tests or simply the Init test, it crashes.

dfeinzimer
dfeinzimer approved these changes Aug 14, 2023
View reviewed changes
Copy link
Collaborator

@dfeinzimer dfeinzimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For what its worth, seems to crash on main/200.1 so I don't think this is a regression. Should we give this its own issue?

@mhdostal
Copy link
Member Author

Should we give this its own issue?

Yes, it's own issue. If it's not a regression, then we'll fix it next release.

@mhdostal mhdostal merged commit c693729 into v.next Aug 14, 2023
@mhdostal mhdostal deleted the mhdBasemapGalleryText_fix branch August 14, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfeinzimer dfeinzimer dfeinzimer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhdostal @dfeinzimer