Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show error text for thumbnail errors #564

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Conversation

mhdostal
Copy link
Member

Displaying the error text for an image load error clogs of the view; don't show the error text.

@mhdostal mhdostal changed the base branch from main to Forms January 19, 2024 20:04
@mhdostal mhdostal marked this pull request as draft January 19, 2024 20:04
@dfeinzimer
Copy link
Collaborator

dfeinzimer commented Jan 19, 2024

This looks good so far, looks like it has the rename changes in it.

--

Oops, sorry jumped the gun, thought my review was already requested. 🙃

@mhdostal mhdostal marked this pull request as ready for review January 19, 2024 20:21
@mhdostal mhdostal requested a review from dfeinzimer January 19, 2024 20:21
@mhdostal
Copy link
Member Author

ha ha, thanks. It's ready now! No name changes...

@mhdostal mhdostal merged commit b8e5ff9 into Forms Jan 19, 2024
@mhdostal mhdostal deleted the mhd/AsyncImageError branch January 19, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants