Skip to content

world-scale: animate the scene view in #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 20, 2024
Merged

world-scale: animate the scene view in #623

merged 2 commits into from
Mar 20, 2024

Conversation

rolson
Copy link
Contributor

@rolson rolson commented Mar 19, 2024

world-scale: animate the scene view in

@rolson rolson requested review from yo1995 and des12437 March 19, 2024 19:52
des12437
des12437 previously approved these changes Mar 19, 2024
View reviewed changes
yo1995
yo1995 previously approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@yo1995 yo1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the default animation speed it looks pretty much like a jump-in rather than a fade-in though.

@rolson rolson dismissed stale reviews from yo1995 and des12437 via 9f8f215 March 19, 2024 22:36
@rolson
Copy link
Contributor Author

rolson commented Mar 19, 2024

With the default animation speed it looks pretty much like a jump-in rather than a fade-in though.

Good point. I slowed it down. Please re-review.

@rolson rolson requested review from des12437 and yo1995 March 19, 2024 22:36
@rolson rolson merged commit 9b4ebd7 into v.next Mar 20, 2024
@rolson rolson deleted the ryan/animateIn branch March 20, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yo1995 yo1995 yo1995 approved these changes

@des12437 des12437 des12437 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rolson @yo1995 @des12437