Skip to content

Remove remaining NavigationViews #695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions AuthenticationExample/AuthenticationExample/HomeView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ struct HomeView: View {

var body: some View {
if let portal = portal {
NavigationView {
NavigationStack {
WebMapsView(portal: portal)
.toolbar {
ToolbarItem(placement: .navigationBarTrailing) {
Expand All @@ -42,7 +42,6 @@ struct HomeView: View {
}
}
}
.navigationViewStyle(.stack)
} else {
SignInView(portal: $portal)
}
Expand Down
3 changes: 1 addition & 2 deletions Examples/ExamplesApp/Examples.swift
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,13 @@ struct Examples: View {
]

var body: some View {
NavigationView {
NavigationStack {
List(lists) { (list) in
NavigationLink(list.name, destination: list)
}
.navigationTitle("Toolkit Examples")
.navigationBarTitleDisplayMode(.inline)
}
.navigationViewStyle(.stack)
}
}

Expand Down
3 changes: 1 addition & 2 deletions Test Runner/Test Runner/Tests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,13 @@ import SwiftUI

struct Tests: View {
var body: some View {
NavigationView {
NavigationStack {
List {
NavigationLink("Basemap Gallery Tests", destination: BasemapGalleryTestView())
NavigationLink("Bookmarks Tests", destination: BookmarksTestViews())
NavigationLink("Feature Form Tests", destination: FeatureFormTestView())
NavigationLink("Floor Filter Tests", destination: FloorFilterTestView())
}
}
.navigationViewStyle(.stack)
}
}