Skip to content

feat: with-nextjs demo app에 AnalyticsClick 추가 #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 2, 2021
Merged

Conversation

jhlee910609
Copy link
Contributor

@jhlee910609 jhlee910609 commented Aug 28, 2021

Description

  • AnalyticsClick을 활용하여, click event 트래킹하도록 수정
    Aug-29-2021 19-27-57

Help Wanted 👀

Related Issues

resolve #
fix #

Checklist ✋

  • PR 타이틀을 {PR type}: {PR title}로 맞췄습니다. (type 예시: feat | fix | BREAKING CHANGE | chore | ci | docs | style | refactor | perf | test) (참고: conventional commits)
  • 모든 변경점들을 확인했으며 적절히 설명했습니다.
  • [x ] 빌드와 테스트가 정상적으로 수행됨을 확인했습니다. (npm run build, npm run test)
  • 깃헙 이슈를 연결하겠습니다. (커밋에 resolve #이슈넘버 적거나 PR생성 후 Linked Issue 추가)

Help Wanted 👀

Related Issues

resolve #
fix #

Checklist ✋

  • PR 타이틀을 {PR type}: {PR title}로 맞췄습니다. (type 예시: feat | fix | BREAKING CHANGE | chore | ci | docs | style | refactor | perf | test) (참고: conventional commits)
  • 모든 변경점들을 확인했으며 적절히 설명했습니다.
  • 빌드와 테스트가 정상적으로 수행됨을 확인했습니다. (npm run build, npm run test)
  • 깃헙 이슈를 연결하겠습니다. (커밋에 resolve #이슈넘버 적거나 PR생성 후 Linked Issue 추가)

@jhlee910609 jhlee910609 changed the title feat: with-nextjs에 AnalyticsClick 추가 feat: with-nextjs demo app에 AnalyticsClick 추가 Aug 28, 2021
@hy57in hy57in added this to the 🧸 Demo 길드 - 3주차 milestone Aug 28, 2021
@jhlee910609 jhlee910609 force-pushed the feat/53 branch 4 times, most recently from f35c082 to d9fb847 Compare August 29, 2021 10:15
@jhlee910609 jhlee910609 self-assigned this Aug 29, 2021
@jhlee910609 jhlee910609 linked an issue Aug 29, 2021 that may be closed by this pull request
@jhlee910609 jhlee910609 marked this pull request as ready for review August 29, 2021 10:32
@jhlee910609 jhlee910609 requested review from alledy and hy57in August 29, 2021 10:32
Copy link
Member

@Leehaeun0 Leehaeun0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 입니다~

Copy link
Member

@hy57in hy57in left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@jiyoon1156 jiyoon1156 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~!

@codecov-commenter
Copy link

Codecov Report

Merging #160 (466eff3) into main (9ac8af2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #160   +/-   ##
=======================================
  Coverage   88.88%   88.88%           
=======================================
  Files           7        7           
  Lines          54       54           
  Branches        3        3           
=======================================
  Hits           48       48           
  Misses          6        6           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ac8af2...466eff3. Read the comment docs.

@jhlee910609 jhlee910609 merged commit 25d3b53 into main Sep 2, 2021
@jhlee910609 jhlee910609 deleted the feat/53 branch September 2, 2021 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Demo Nextjs - click event
5 participants